Skip to content

ED2208: end the BUSY wait at the first high #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovyan03 merged 1 commit into from
Oct 15, 2026
Merged

ED2208: end the BUSY wait at the first high #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions src/lgfx/v1/panel/Panel_ED2208.inl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,37 +275,19 @@ namespace lgfx
_bus->writeData(data, 8);
}

// Waits up to `timeout` ms for the controller to be idle. BUSY counts as released only
// after it has stayed high for 200 ms: a short high between the steps of an AUTO
// sequence is not the end of it.
// Waits up to `timeout` ms for the controller to be idle. BUSY stays low for the whole
// AUTO sequence (no short high between its steps was seen at 0.1 ms sampling), so the
// first high ends the wait.
bool Panel_ED2208::_wait_busy(uint32_t timeout)
{
_bus->wait();
uint32_t start_time = millis();
if (_cfg.pin_busy < 0)
{ // No BUSY pin: wait out the time a refresh may take.
while (displayBusy())
{
if (millis() - start_time >= timeout) { return false; }
lgfx::delay(10);
}
return true;
}
// Right after this instance started a refresh, a high BUSY at the entry may also be
// such a short high, so it needs the 200 ms as well.
bool confirm = _refresh_started && (millis() - _refresh_ms < REFRESH_TIMEOUT_MS);
if (!confirm && gpio_in(_cfg.pin_busy)) { return true; }
uint32_t high_since = 0;
bool high = false;
for (;;)
while (displayBusy())
{
uint32_t now = millis();
if (!gpio_in(_cfg.pin_busy)) { high = false; }
else if (!high) { high = true; high_since = now; }
else if (now - high_since >= 200) { return true; }
if (now - start_time >= timeout) { return false; }
if (millis() - start_time >= timeout) { return false; }
lgfx::delay(10);
}
return true;
}

void Panel_ED2208::_init_sequence(void)
Expand Down
Loading