Repository navigation
ToughC5: select 650 mA, not 830 mA, as the high charge current step - #395
Merged
Merged
Conversation
The charger's CHG_PROG pin (IOE1 G1) switches between 180 mA and 650 mA, the same two steps as CoreMatrix. The code assumed 830 mA for the high step, so setChargeCurrent() with a request between 650 and 829 mA picked 180 mA, and the applied current was reported as 830 mA.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The charger's CHG_PROG pin (IOE1 G1) switches between 180 mA and 650 mA, the same two steps as CoreMatrix.
setChargeCurrent()assumed 830 mA for the high step, so a request between 650 and 829 mA selected 180 mA andapplied_mAreported 830 mA.This corrects the threshold, the reported value and the comments in
Power_Class.hpp/Power_Class.inl. No API change.