Repository navigation
Conversation
A Lua function converted to a script value and back was wrapped in a new Rust callback each time: calling it went Lua -> Rust -> Lua, and it was not equal to the function passed in.
Changed Files
|
This was referenced Nov 13, 2026
An error occurred while trying to automatically change base from
agent/lua-stack-conversion
to
main
November 14, 2026 16:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Lua function converted to a
ScriptValueand back was wrapped in a new Rust callback every time: the script got a different function than the one it passed in, and calling it went Lua → Rust → Lua.DynamicScriptFunctioncan now record the script's own function it calls (with_script_function/script_function::<T>()). The Lua backend stores themlua::Functionthere and hands it back as it is when the value returns to the same Lua state (compared byWeakLua), any other state still gets a wrapper. Curried functions don't keep it.Stacked on #720 (same file).
Measured on the reactive ui stack (#719 + #720 + this, prebuilt binaries, alternating rounds), where component props holding handlers go to Rust and back:
Mounting doesn't change: creating the wrapper was a small part of a slot. Handlers called from Lua get cheaper.