Skip to content

M1: make COMTRADE open native-only - #305

Merged
masarray merged 44 commits into
fix/fat-workstation-convergencefrom
fix/gui-ux-comtrade-inprocess-m1
Sep 14, 2026
Merged

M1: make COMTRADE open native-only#305
masarray merged 44 commits into
fix/fat-workstation-convergencefrom
fix/gui-ux-comtrade-inprocess-m1

Conversation

@masarray

@masarray masarray commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Scope

  • keep Fault Records COMTRADE Open strictly in-process/native-only
  • restore the field-accepted rich ARSAS COMTRADE workstation without launching the external ArdIrec Qt UI
  • preserve FAT/workstation UX convergence and Live Monitor compact header
  • harden native FAT capture/persistence before public release
  • prepare ARSAS 1.6.36 stable publication metadata

COMTRADE workstation provenance

The restored workstation comes from ARSAS commit c3e2ac3ef6e6a3a49f47c5155a0ba4a7c00bcb6b and retains Time Signals, Phasor, Harmonics, six-loop native Locus, cursor measurements, recorded-value engineering semantics and the bounded investigation shell.

Pinned ArdIrec analysis engine:

  • repository: masarray/ardirec
  • ref: feat/p1d5-arsas-analysis-bridge
  • commit: 7dbc7149db668126a493ce338264363a6ec5ec00
  • ABI: 1, native-only
  • capabilities: cursor measurement, channel semantics, value representation, status state, digital edge snap, phasor, harmonics, distance locus

Native-only guards

  • no ardirec.exe launch
  • no Qt runtime packaging
  • no Process.Start COMTRADE fallback
  • Fault Records routes to the managed/native bridge and ARSAS ComtradeWorkspaceWindow
  • installer/release smoke rejects external ArdIrec/Qt runtime files

FAT / Engineering hardening

  • obsolete first-run FAT launcher removed
  • FAT workspace shell aligned with Engineering tabs
  • Live Monitor title + bounded search + filters converged into one row
  • FAT capture requires a real initialized live IEC 61850 observation
  • persistence uses durable SCL identity or endpoint identity instead of ephemeral runtime DeviceId
  • collision-safe evidence paths survive harmless IED display-name changes
  • damaged state files are never overwritten by recovery state
  • restart/rename/collision behavior is regression-tested

Main integration

Current main (3ad21a631d09a175a8030a0764fd880d0ee77560) is now an ancestor of this branch through merge commit 22902b29002481cf7fa8f7328533d8a22a847f19. Main-owned coordination/architecture documentation, fault-record transfer reliability code and its bounded FIFO regression were restored exactly in 4fd863322f0bb247911cd241f71c366c015449d4. compare main...HEAD reports behind_by=0.

Release candidate

  • version: 1.6.36
  • current head: 4fd863322f0bb247911cd241f71c366c015449d4
  • .release/windows.json publication request: 24
  • public v1.6.35 remains untouched

Validation

Exact combined-head GitHub Actions are running: Build ARSAS #2768, IO List Testing #1321, SV evidence #1752, COMTRADE integration #205 and Windows installer #929. This PR remains Draft until all five pass. After CI, this change may land into staging PR #296 to produce the exact physical FAT field candidate; the #296 field gate still blocks merge to main and public release until the real-IED workflow passes.

* P1C: add native WPF COMTRADE phasor visualization

* P1C: add native WPF COMTRADE harmonic visualization

* P1C: pin ArdIrec native analysis bridge

* P1C: consume native ArdIrec phasor and harmonic analysis

* P1C: add Waveform Phasor Harmonics workspace modes

* P1C: wire native phasor and harmonic views into workspace

* P1C: verify managed phasor and harmonic bridge interop

* ci: cover P1C COMTRADE analysis views

* P1C: scale harmonic axis to actual distortion magnitude
…t-v1

docs: add production engineering contract for AI agents
Field-accepted COMTRADE workstation integration from the P1D stack through P1D.7.

Includes synchronized Time Signals, Phasor, Harmonics, native six-loop Locus, RMS/PRI-SEC presentation, cursor measurements, first-click fault-record reliability, deterministic analog-before-digital ordering, Clear/Auto state authority, retained/screen-space waveform rendering, synchronous cursor transforms, bounded latest-wins analysis/readout scheduling, and bridge-only packaging.

Exact merge-prep head passed Build ARSAS #2571, SV #1576, COMTRADE integration #171, and Windows Installer #893 against current main. The production AGENTS.md from main is preserved. ArdIrec PR #41 was merged first and the ARSAS lock remains pinned to the exact field-tested bridge commit. FAT workstation files/branches are intentionally untouched and remain under their independent field gate.
@masarray
masarray changed the base branch from main to fix/fat-workstation-convergence September 13, 2026 23:28
@masarray
masarray marked this pull request as ready for review September 14, 2026 13:41
@masarray
masarray merged commit 384e2fe into fix/fat-workstation-convergence Sep 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant