Repository navigation
fix(windows): validate reparse rejection without link fixtures (#2924) - #2928
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows directory-rejection test fails with error 1314 when preparing real symbolic links. Replace that specific fixture with simulated reparse metadata while exercising the same private verification algorithm used by production. Public signatures, real metadata inspection, typed errors and directory-opening behavior remain unchanged.
Remove the corresponding AC_REQUIRE_WINDOWS_LINK_TESTS consumer and CI producer explicitly. This replacement no longer verifies real Windows symlink/junction metadata or that filesystem integration; other existing link tests remain unchanged and are tracked separately in #2922.
Validation: locked/offline all-target check, scoped formatting, six exact tests and nine guard assertions pass on integrated HEAD 19f8593. All SCC member sets and module pairs remain identical; module-arc record is byte-identical. Grinch approved the code and the conflict-free integration with main 4537d4b. The corrective diff remains limited to two files.
Plan v7 approved by the user; Plan-SHA256 4224C37C0C76BE754E86BDE31062C68B48529C211CFA876A20763B7707BFCECE. P01 #2892 remains suspended and preserved in its original checkout while this explicitly authorized worktree workaround lands. No distribution build requested.
Closes #2924