Repository navigation
feat(team): import agents using source project identity (refs #3072) - #3082
Conversation
|
Incoming-main triage for P02: main advanced from 08bb43a to fe59d4d. The incoming paths are src-tauri/src/commands/config.rs, src-tauri/src/config/settings.rs (#3067) and CHANGELOG.md (#3084). entity_creation.rs imports and calls settings directly, so this takes the full integration path under Step 9.5. The previous regression run 39066036611 was cancelled and confirmed completed on head a311746 before local mutation. The developer is integrating main locally on the same feature branch. Focused integration review and validation/POST will run on the resulting head before it is pushed; full PR CI must then pass on that exact published head. Prior local PASS reports remain historical evidence for a311746, not validation of the forthcoming integrated tree. The frozen plan v2, phase P02, issue mapping and authorized scope remain unchanged. |
|
|
Step 9.5 incoming-main triage: origin/main advanced to 12cf115 (seven commits, #3077/#3063). Team judgment: UNRELATED to P02. Keep the reviewed head b7033fb and its CI; no branch update or CI restart is required for this delta. Incoming paths:
The change controls visibility and save normalization for container options in Settings. Its shared-type addition is the optional AppSettings.containerOptionsEnabled field; the matching Rust field already exists in this PR head. No Rust source, manifest, lockfile, workflow or build script changes. No P02 wire, AgentInfo, TeamWizard type, create_team/list_all_agents change; NewTeamModal, EditTeamModal and ipc.ts are unchanged and do not use the changed Settings helpers. The Rust Grinch independently confirmed there is no affected P02 import, dependent or runtime contract. Evidence: room-24/room-shared/i3068-validation/P02/drift-12cf1153-review.md. Required and triggered CI must still pass on exact head b7033fb before merge. |
|
Final Step 9.5 triage: main additionally advanced from 12cf115 to ea5d4ab (#3090/#3081, message snapshots). Team judgment: UNRELATED to P02; retain the green head b7033fb. Incoming files: src-tauri/src/api/actuation.rs, api/handlers/send.rs, cli/send.rs, lib.rs and phone/messaging.rs. The archive flow has no call to/from entity_creation, no P02-used signature or team guard change, and no command registration change. It writes only .ac/message-archive, outside Agent/Team roots and discovery. No manifest, lockfile, workflow or module record change. The Rust Grinch independently verified contracts, state and paths: room-24/room-shared/i3068-validation/P02/drift-ea5d4abc-review.md. The earlier Settings delta remains separately classified as unrelated. CI run 39076334013, attempt 2, is SUCCESS on exact head b7033fb. Every required and triggered check is SUCCESS, reconciled against the 14 contexts in ruleset 15279066. The initial frontend-regression failure in ProjectPanel.context-menu.test.tsx (callback count 1 expected/2 observed) did not reproduce in the single authorized same-head recurrence; its original logs are retained and the cause remains unknown. No product correction or condition change was made. |
New Team currently loses the source project when selected agents become portable references. This adds optional source identity to create_team and destination-aware discovery, copies foreign Agent Matrices before publishing the team, and preserves compatibility with existing local calls.
The source-aware path validates the whole selection, rejects collisions and ambiguous sources, preserves accumulated provenance, and publishes config exclusively after every copy finishes. Cleanup removes only recorded output whose identity and bytes still match. The change is limited to entity_creation.rs; the frontend consumer follows in P03.
Closes #3072. Phase P02 of #3068; P01 landed in #3075. This PR closes only the phase child.
Validation on b7033fb:
Integrated main 29fad1b without conflicts, including upstream 0.45.1 version metadata and CI screenshot-count corrections. All 266 Rust blobs are identical to the reviewed and tested 0e24f58 tree. The diff against current main contains only entity_creation.rs; original execution base 08bb43a remains recorded.
Whitespace control: target-to-head diff check passed. The original-base check reports four inherited Markdown line breaks in docs/releases/v0.45.1/release-plan.md:5-8, identical in main; both reviewers classified these as upstream content. No upstream cleanup is included.
Earlier validation on 0e24f58 had one full-suite run with a lost terminal receipt, preserved as UNKNOWN, followed by one authorized successful repetition. Its logs remain historical evidence; they are not substituted for the successful b7033fb executions above.
Frozen plan v2 / P02: plan SHA256 664D6CD1FB4EC3FD0E63E24514F0510E85ED2B66C1A2616A187F4916A9F9E9BF; phase SHA256 9ED82885109FF9BFB8243BD0D15B971BDBEC3946B9D1E70405EB46288C78B459. Local evidence: room-24/room-shared/i3068-validation/P02/integrated-b7033fbd.
Full cross-platform CI runs with ci:full and must pass on the exact published head. No final distributable build was requested.