Repository navigation
refactor: sanitize Rust codebase, batch 2 (refs #3176) - #3178
Merged
Merged
Conversation
…mmands/session/ (#3172)
…oject_path/save/owner (#3172)
Move the production code of phone/mailbox.rs into 22 private submodules under phone/mailbox/, in dependency order so sibling modules form a DAG. mailbox.rs now only declares the children and re-exports the items that were already pub/pub(crate). The MailboxPoller impl is split into several impl blocks. Items, fields and methods used across the new siblings become pub(crate). Source-scan tests read the new files. Cycle baseline change: SCC 554acc49e7a211d1 (89 members) shrinks. phone::mailbox and phone::terminal_snapshot leave it; the rest becomes eb99a5c4b6de1586 (85) and fa5266e34a30725c (cli::create_agent, cli::create_agent_matrix). No module joined any cycle.
…mmands/session/ (#3172)
…ance/file/help/blocking_menu (#3172)
…s.rs + src/tests/ (#3176)
…ng_agents_catalog/tests (#3176)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3176
Closes batch 2. Batch 1 and batch 2 up to
0af7621already reachedmainthrough #3179 (merge commite939e9c). This PR brings the rest of batch 2 (22 commits,e939e9c->e3f7f3c), including the census update for the whole batch.Measures (
src-tauri/src)mainbefore batch 1 (6058741)e939e9c)e3f7f3c)mod.rsmod x { }#[test]outsidetests.rs/tests/Targets finished in this part
session/selection.rs(-> 440),pty/local_backend.rs(-> 884),config/injected_messages.rs(-> 636),cli/list_peers.rs(-> 608),testability/ui_automation.rs(-> 796). Half done, back to pending:config/local_config_io.rs(-> 3191),resource_monitor/registry.rs(-> 620,registry/tests.rsstill 2291).Fixes from CI in this part
clippy-linux: Windows-only test imports gated inconfig/injected_messages.rs(02e993d) andsession/selection.rs(43d0eae).sanitizing:file_size: no file over 1000 lines grows againstmain(795a13c,87d5757,7c235bf).c4_state_key_censusandspawn_search_path_inventoryupdated for all batch 2 moves (e3f7f3c); the owner scope inc4_state_key_censusnow includes the owner's child modules.Cycle baseline change
10a2867commands::resource_monitorandcommands::windowleft the main cycle (selection split)0f7d406c9c4eb3bcecfea84a5c2c6182ad68adaui_automationsplitKnown open gate failures (deferred, not new debt)
rust-regression*,clippy-linux,test-debt"Baseline grew"/"STALE baseline entry").tauri_fileson new child files that hold moved code (session/selection/*,testability/ui_automation/{backend_watchdog,liveness}.rs).Rooms
room-30, room-31, room-32, room-33, room-34, room-35, room-36.