Repository navigation
refactor: sanitize Rust codebase, batches 1-2 snapshot (refs #3176) - #3179
Merged
Merged
Conversation
…mmands/session/ (#3172)
…oject_path/save/owner (#3172)
Move the production code of phone/mailbox.rs into 22 private submodules under phone/mailbox/, in dependency order so sibling modules form a DAG. mailbox.rs now only declares the children and re-exports the items that were already pub/pub(crate). The MailboxPoller impl is split into several impl blocks. Items, fields and methods used across the new siblings become pub(crate). Source-scan tests read the new files. Cycle baseline change: SCC 554acc49e7a211d1 (89 members) shrinks. phone::mailbox and phone::terminal_snapshot leave it; the rest becomes eb99a5c4b6de1586 (85) and fa5266e34a30725c (cli::create_agent, cli::create_agent_matrix). No module joined any cycle.
…mmands/session/ (#3172)
…ance/file/help/blocking_menu (#3172)
…s.rs + src/tests/ (#3176)
…ng_agents_catalog/tests (#3176)
…dules (#3176) Cycle baseline change: SCC shrink, retired 03080aaa698f33b1 (54) -> 0f7d406c9c4eb3bc (53); left session::context_alerts, joined none.
… and matching children (refs #3176)
…livery, screen and markers (#3176)
…nd discovery modules (#3176)
a71c883 moved the sibling modules derived_agent_id_home_tests (3 tests) and p02_schema_launch_tests (1 test) under config::agent_command::tests. The IS #2431 focused step filters on that path, so it now runs those 4 tests as well: 92 -> 96 on Linux (100 on Windows). The old 92 tests still run; only the count follows the module move.
… to registry/tests.rs (#3176)
…cted_messages/tests.rs (#3176)
|
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3176
Refs #3172
Merges batch 1 (#3172, closed PR #3175) and batch 2 so far, from a fixed snapshot of
refactor/3176-sanitize-rust-codebaseat0af7621. The shared branch keeps moving while fixers work, which cancelled every full CI run on #3178; this snapshot is the exact SHA that ran the full CI (run 39907201326). #3178 stays open for the batch 2 work after this SHA.Measures (
src-tauri/src,main@6058741->0af7621)mod.rsmod x { }#[test]outsidetests.rs/tests/Known open gate failures (deferred)
rust-regression*,clippy-linux,test-debt"Baseline grew"/"STALE baseline entry"). Not new debt; follow-up to let the check accept re-anchoring with an identical hash, or to reduce each function.tauri_edge(06),global_state(08) andprocess_env(09) count files, so splitting a file raises the count with the same code.c4_state_key_censusandspawn_search_path_inventoryfile lists are updated at the end of the campaign.Files modified
See the "Files modified" list in #3176 and #3172.
Rooms
room-30, room-31, room-32, room-33, room-34, room-35, room-36.