MAINT: Update Registry APIs - #2550
Merged
Richard Lundeen (richlundeen) merged 13 commits intoSep 16, 2026
Merged
Richard Lundeen (richlundeen) merged 13 commits into
Richard Lundeen (richlundeen) merged 13 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471c-a08b-28df698d8109
Type converter file inputs as Path instead of special-casing strings in the backend: AddImageVideoConverter.video_path is now a Path, so the registry describes it as an input file and REST treats it as an upload like every other Path parameter. Drop the per-parameter MIME/signature allowlist. Uploads are stored verbatim because any file type is a legitimate payload; the generated file name means a declared MIME type only picks an extension. Content restrictions now live only in the media route, which serves active document types as neutralized downloads without renaming stored files. Mark the temporary catalog projections consistently so reviewers can see the whole concept is deleted once the UI moves to /types. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577
Richard Lundeen (richlundeen)
changed the title
Preserve registry-backed target type metadata while adopting main's strict auth-mode validation and concurrency cleanup. Reset the technique registry in the pre-registration test so it tests custom-first registration under strict duplicate-name rejection. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577
Treat the media extension allowlist as an inline-rendering allowlist rather than an access allowlist. Any stored file type, including executables and active documents, can be downloaded as opaque bytes while only known-safe media types receive renderable content types. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577
Keep constructor inputs in a backend-owned temporary directory, independent of result storage. Clean partial writes on failure and remove owned inputs and dependent registry entries at shutdown. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577
Add a typed registry base that builds and stores named instances. Use it for converter, target, and scorer registries while keeping the instance container storage-only. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577 # Conflicts: # pyrit/converter/add_image_to_video_converter.py # tests/unit/backend/test_converter_service.py
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c9eafadc-3a00-471b-b61b-68ba4d656577
Roman Lutz (romanlutz)
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/converters/typesAPIs, plus the target registry consistency needed by later stack layerspathlib.Pathconstructor metadata and uploaded data-URI persistence without exposing server paths/api/converters/catalogand/api/targets/catalogas temporary compatibility projections for the unchanged main UI; the higher chat-migration layer will remove them