Repository navigation
Resolve unit-test Git dependencies through PATH - #2162
Merged
Tyrie Vella (tyrielv) merged 3 commits intoNov 10, 2026
Merged
Conversation
Find Git through PATH instead of a fixed system installation directory. Share the resolver across the Git-dependent test fixtures. Preserve missing-Git failure and skip policies. Keep metadata-only worktree tests on a mock Git path. Add filesystem-only tests for search order, quoted directories, empty entries, relative paths, and absent Git. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Keep semicolons inside quoted PATH directories. Add a filesystem-only regression case for that directory shape. Compare resolved Windows paths without case sensitivity. Use one Git prerequisite guard across authentication test entry points. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Tyrie Vella (tyrielv)
marked this pull request as ready for review
November 10, 2026 18:00
Tyrie Vella (tyrielv)
enabled auto-merge
November 10, 2026 18:00
|
[KeithBot]: Approach: Right layer: a test-only PATH resolver replaces every fixed Git path in the unit suite; the product's registry lookup can't see PATH-only Git and is null under MockPlatform. Validation
🤖 KeithBot · claude-opus-5.5, gpt-6.1-sol, gemini-4-argon + approach review · reply on a thread to dispute |
Resolve Git through PATH in both tests that reject the shared config ID. Keep all three enlistment constructions on the real Git executable. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
|
[KeithBot]: ✅ Resolved · iteration 2 (
Validation
Approving. 🤖 KeithBot · recheck by claude-opus-5.5 · reply on a thread to dispute |
Keith Klein (KeithIsSleeping)
approved these changes
Nov 10, 2026
This was referenced Nov 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and Context
Several unit tests require Git at
C:\Program Files\Git\cmd\git.exe.Release agents provide Git through
PATH, but that executable is not at the fixed location.The authentication and worktree configuration tests fail, while other Git-dependent tests skip.
Changes
PATHin order and returns an absolute executable path.PATH.Production Git discovery and native hook executable tests remain unchanged.
A follow-up PR #2163 will examine moving some tests from the unit test suite to the functional test suite due to such dependencies.