Repository navigation
Move system-dependent unit coverage to functional components - #2163
Draft
Tyrie Vella (tyrielv) wants to merge 4 commits into
Draft
Tyrie Vella (tyrielv) wants to merge 4 commits into
Tyrie Vella (tyrielv) wants to merge 4 commits into
Conversation
Find Git through PATH instead of a fixed system installation directory. Share the resolver across the Git-dependent test fixtures. Preserve missing-Git failure and skip policies. Keep metadata-only worktree tests on a mock Git path. Add filesystem-only tests for search order, quoted directories, empty entries, relative paths, and absent Git. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Keep semicolons inside quoted PATH directories. Add a filesystem-only regression case for that directory shape. Compare resolved Windows paths without case sensitivity. Use one Git prerequisite guard across authentication test entry points. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Preserve real Git, process, HTTP, and named-pipe checks in local functional fixtures. Keep isolated policy, parser, filesystem, native hook, and in-process Windows API coverage in the unit suite. Run local functional components in PR and release build jobs through the existing runner and service lifecycle. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Use the product Git installation resolver for functional tests and derive Bash from the same installation. Initialize the platform before settings. Complete filesystem setup before environment mutation. Quote test result paths and preserve the surviving unit fixture encoding. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and Context
Unit tests currently start Git, shell commands, and the mount executable, and use real HTTP and named-pipe connections.
These dependencies require machine setup and place integration failures in the unit-test gate.
The real behavior checks remain important and must not disappear behind mocks.
Merge order: #2162 first, then this PR.
This branch contains the current head of #2162 and adds the test migration on top.
Functional tests use the same Git installation resolver as GVFS.
Changes