Repository navigation
feat(kotlin): make ARC the default runner for the Kotlin workflows - #360
Merged
Merged
Conversation
use-arc-runners now defaults to true in the Kotlin PR, Sonar, coverage and deploy workflows; callers opt out with use-arc-runners: false. The PR and Sonar workflows use the S3 cache only when the caller passes the bucket secrets and fall back to the GitHub cache otherwise, so callers need no changes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
JesperTerkelsen
force-pushed
the
feat/arc-default-kotlin
branch
from
September 30, 2026 14:22
cf542dc to
7623080
Compare
This was referenced Sep 30, 2026
JesperTerkelsen
marked this pull request as ready for review
September 30, 2026 15:29
JesperTerkelsen
requested review from
maoanran
and removed request for
a team
September 30, 2026 15:29
Public repos keep their current runners even when use-arc-runners is true: a fork PR runs the fork's own workflow files, and the ARC runner group disallows public repositories, so those jobs would otherwise queue forever. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
joscdk
approved these changes
Sep 30, 2026
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Makes the self-hosted ARC runners the default for Kotlin CI and deploys.
use-arc-runnersnow defaults totruein the workflows service repos call directly:pull-request-kotlin.ymlsonar-cloud.ymlcode-analysis.yml)deploy-kotlin.yml,deploy-kotlin-v2.ymluse-arc-runners: false.use-arc-runnersstill takes precedence overuse-blacksmith-runners. Today that's service-energy (true) and service-ocpp and changelog-monorepo (false, GitHub-hosted runners).component-test-kotlin.yml,component-build.ymlandcomponent-service-profile-kotlin.ymlkeepfalseas their own default, anddeploy-kotlin(-v2)pass the value down to them. Sodeploy-generic(-v2),deploy-python, the Bun and React workflows, and directcomponent-buildcallers (infra-portal, changelog-monorepo) stay where they are.No caller changes needed. On ARC, the PR and Sonar workflows use the S3 cache when the caller passes
GH_ACTION_ACCESS_KEY_ID/GH_ACTION_SECRET_ACCESS_KEY, and fall back to the GitHub cache otherwise. Today only 2 of the 78 PR and Sonar calls pass them. The choice is made once, in a workflow-levelS3_CACHEenv. Tailscale and the in-cluster Sonar URL still depend on the runner, not the cache backend.Why this is safe to default
java-versionagainst its Gradle toolchain. None conflict (36 match exactly; 7 have no toolchain and use the installed JDK). This matters because the ARC image has no preinstalled JDK.docker build: it doesn't get CodeArtifact. feat(build): keep Dockerfile cache mounts between ARC image builds #359 keeps its/root/.gradlecache mount warm between ARC builds.Public repositories never use ARC
Every read of the input is
(inputs.use-arc-runners && github.event.repository.private). In a public repo, the workflows keep today's runners, even withuse-arc-runners: true. That covers library-ocpp and ocpp-emulator, which callpull-request-kotlin, and any future public repo, so they need no per-repo opt-out.This check isn't the security boundary. A fork PR runs the fork's own workflow files and could name an ARC label directly. The boundary is the org runner group: https://github.com/monta-app/kube-manifests/pull/7727 moves every ARC scale set into the new
ARCrunner group, which disallows public repositories. This check keeps public repos' shared-workflow jobs on runners they can use, instead of leaving them queued.Merge order
All 42 per-repo opt-in PRs from the sweep are merged, so this can merge now. https://github.com/monta-app/kube-manifests/pull/7727 is independent: it closes the fork-PR path to ARC, which exists today regardless of this PR.
Earlier plan, kept for reference:
main, so their next production deploy after this merges will be on ARC.Gaps
arc-runnerIRSA role read and write the cache bucket would give every repo S3 with no secrets.🤖 Generated with Claude Code