Repository navigation
feat(workflows): forward the S3 cache secrets through the generic and Python deploys - #368
Merged
Merged
Conversation
… Python deploys deploy-generic, deploy-generic-v2 and deploy-python accept the optional GH_ACTION_* secrets and pass them to component-build, so their image builds on ARC can keep Dockerfile cache mounts in S3 like deploy-kotlin. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
JesperTerkelsen
marked this pull request as ready for review
October 1, 2026 07:42
JesperTerkelsen
requested review from
chandrashekar-dhar
and removed request for
a team
October 1, 2026 07:42
tobias0106
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
deploy-generic,deploy-generic-v2anddeploy-pythonaccept the optionalGH_ACTION_ACCESS_KEY_ID/GH_ACTION_SECRET_ACCESS_KEYsecrets and forward them tocomponent-build, asdeploy-kotlin(-v2)already does.Why?
Since #367 these deploys build their images on ARC.
component-buildkeeps Dockerfile cache mounts in S3 when it gets these secrets, and in the slower GitHub cache otherwise. Callers of these three workflows had no way to pass them: passing a secret the called workflow doesn't declare is invalid. This unblocks the per-repo PRs that add them.Optional and backwards compatible.
nojira
🤖 Generated with Claude Code