Skip to content

feat(workflows): forward the S3 cache secrets through the generic and Python deploys #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JesperTerkelsen merged 1 commit into from
Oct 1, 2026
Merged

feat(workflows): forward the S3 cache secrets through the generic and Python deploys #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/deploy-generic-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ on:
AWS_ACCOUNT_ID:
required: true
description: 'AWS Account ID for ECR and deployment access'
GH_ACTION_ACCESS_KEY_ID:
required: false
description: "AWS access key for the S3 cache bucket, used on ARC. Without it ARC builds use the GitHub cache."
GH_ACTION_SECRET_ACCESS_KEY:
required: false
description: "AWS secret key for the S3 cache bucket, used on ARC. Without it ARC builds use the GitHub cache."
MANIFEST_REPO_PAT:
required: true
description: 'GitHub PAT to commit/push to kube-manifests repo'
Expand Down Expand Up @@ -181,6 +187,8 @@ jobs:
AWS_CDN_ACCESS_KEY_ID: ${{ secrets.AWS_CDN_ACCESS_KEY_ID }}
AWS_CDN_SECRET_ACCESS_KEY: ${{ secrets.AWS_CDN_SECRET_ACCESS_KEY }}
NEXT_SERVER_ACTIONS_ENCRYPTION_KEY: ${{ secrets.NEXT_SERVER_ACTIONS_ENCRYPTION_KEY }}
GH_ACTION_ACCESS_KEY_ID: ${{ secrets.GH_ACTION_ACCESS_KEY_ID }}
GH_ACTION_SECRET_ACCESS_KEY: ${{ secrets.GH_ACTION_SECRET_ACCESS_KEY }}

deploy:
name: Deploy
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/deploy-generic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ on:
AWS_ACCOUNT_ID:
required: true
description: 'AWS Account ID for ECR and deployment access'
GH_ACTION_ACCESS_KEY_ID:
required: false
description: "AWS access key for the S3 cache bucket, used on ARC. Without it ARC builds use the GitHub cache."
GH_ACTION_SECRET_ACCESS_KEY:
required: false
description: "AWS secret key for the S3 cache bucket, used on ARC. Without it ARC builds use the GitHub cache."
MANIFEST_REPO_PAT:
required: true
description: 'GitHub PAT to commit/push to kube-manifests repo'
Expand Down Expand Up @@ -170,6 +176,8 @@ jobs:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
AWS_CDN_ACCESS_KEY_ID: ${{ secrets.AWS_CDN_ACCESS_KEY_ID }}
AWS_CDN_SECRET_ACCESS_KEY: ${{ secrets.AWS_CDN_SECRET_ACCESS_KEY }}
GH_ACTION_ACCESS_KEY_ID: ${{ secrets.GH_ACTION_ACCESS_KEY_ID }}
GH_ACTION_SECRET_ACCESS_KEY: ${{ secrets.GH_ACTION_SECRET_ACCESS_KEY }}

deploy:
name: Deploy
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/deploy-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ on:
AWS_ACCOUNT_ID:
required: true
description: 'AWS Account ID for ECR and deployment access'
GH_ACTION_ACCESS_KEY_ID:
required: false
description: "AWS access key for the S3 cache bucket, used on ARC. Without it ARC builds use the GitHub cache."
GH_ACTION_SECRET_ACCESS_KEY:
required: false
description: "AWS secret key for the S3 cache bucket, used on ARC. Without it ARC builds use the GitHub cache."
MANIFEST_REPO_PAT:
required: true
description: 'GitHub PAT to commit/push to kube-manifests repo'
Expand Down Expand Up @@ -142,6 +148,8 @@ jobs:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
AWS_CDN_ACCESS_KEY_ID: ${{ secrets.AWS_CDN_ACCESS_KEY_ID }}
AWS_CDN_SECRET_ACCESS_KEY: ${{ secrets.AWS_CDN_SECRET_ACCESS_KEY }}
GH_ACTION_ACCESS_KEY_ID: ${{ secrets.GH_ACTION_ACCESS_KEY_ID }}
GH_ACTION_SECRET_ACCESS_KEY: ${{ secrets.GH_ACTION_SECRET_ACCESS_KEY }}

deploy:
name: Deploy
Expand Down
Loading