Repository navigation
quest: apply the wildcard/cluster audit #4629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
911f685
quest: apply the wildcard/cluster audit
kixelated e11ef17
quest(cluster-routing): edge and core tiers replace warm/cold routing
kixelated 0cc11ed
quest(cluster-routing): path vector over edge/core tiers, no link-state
kixelated 5789867
quest(cluster-routing): edge links use tls://
kixelated 9ff4937
quest: role-less relays bridge a region-by-region migration
kixelated 65cc2f9
quest: promote path hunting to m0 with a lite-06 hold-down
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # [M] A withdrawn path stops hunting | ||
|
|
||
| ## Goal | ||
|
|
||
| When a broadcast ends, each relay in a lite-06 mesh retracts it about once, | ||
| instead of re-announcing stale alternatives. Today one withdrawal on live's | ||
| 34-relay graph costs hundreds to over a thousand extra announce starts, and | ||
| on Kick dev an ended name drew 575 to 57,805 mesh announce starts (median | ||
| about 13,000) while live names drew one flood (moq-dev/moq.pro#2116). New | ||
| and removed routes still propagate at once, and no wire changes. | ||
|
|
||
| ## Plan | ||
|
|
||
| Promoted from the cluster routing line to m0 on 2026-09-30: it is today's | ||
| partial-mesh hunting that #4399 left open, and it is hurting production. | ||
|
|
||
| Decided (2026-09-30), lite-06, no wire change: | ||
|
|
||
| - A route *update*, where a relay's advertised route for a path switches to a | ||
| different route, waits a short hold-down before it is re-advertised. A new | ||
| path (nothing advertised yet) and a removal (nothing left) go out at once. | ||
| - So when the best route is withdrawn and an alternative remains, the relay | ||
| retracts at once and re-announces the alternative only if it survives the | ||
| hold-down. Stale alternatives are withdrawn inside that window and never | ||
| spread. A genuine failover, where a link dies but the origin still | ||
| publishes, is delayed by the hold-down; pick the value from the repro, and | ||
| report the failover cost it adds. | ||
| - Check the interaction with #4399's withdrawal hiding and with | ||
| subscriptions already pinned to a route (fronts keep serving from a live | ||
| source; only advertisements are held). | ||
|
|
||
| Test first: land moq.pro's in-process repro upstream (real lite-06 sessions | ||
| over the mock transport on live's 34-relay graph, mocked time), asserting | ||
| about one retraction per relay for a single withdrawal from a non-hub | ||
| publisher, plus a failover test where a link dies and the path comes back | ||
| through another route after the hold-down. It must fail on `main` today. | ||
|
|
||
| Then moq.pro moves its pin and confirms about one retraction wave per ended | ||
| name on Kick dev after a deploy the user approves (moq.pro's own quest). | ||
|
|
||
| If no hold-down closes it, the fallback is a per-origin seqno on cluster | ||
| links in the wip lite version; report before building it. | ||
|
|
||
| Public API: none expected. Wire: none. | ||
|
|
||
| ## Related | ||
|
|
||
| - [Cluster routing](/quest/m1/cluster-routing/README.md) - tiers shrink the core graph this hunts on | ||
| - [Cross-relay delivery under bursts](/quest/m1/cross-relay-bursts.md) - closed broadcasts announced for minutes, the same symptom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Preserve a request-loop invariant across core-session loss
Loop-free advertised hop lists do not make per-hop request reselection loop-free. The allowed core graph can contain a cycle across three regions. After their common upstream D disconnects, A/B/C can still hold stale alternatives [P,D,B], [P,D,C], and [P,D,A]: A requests B, B excludes A and requests C, then C excludes B and requests A. Each choice passes the immediate-peer check. Lost sessions only drop their routes; they do not apply explicit-withdrawal hiding to every path through D (origin.rs:3404–3408). The front cache coalesces the repeated request, leaving a circular wait until routing converges.
Selection now drops the end-to-end visited-relay protection. Retain a request-loop guard or another demonstrated invariant, and include this cyclic-core loss case in the measurement before declaring hop lists sufficient. Tiering removes edge transit but does not remove core cycles.
(Written by OpenAI Codex)