Skip to content

chore(interop): rustfmt the rust tail client - #5377

Merged
kixelated merged 1 commit into
mainfrom
chore/rustfmt-interop-tail
Oct 13, 2026
Merged

kixelated merged 1 commit into
mainfrom
chore/rustfmt-interop-tail

Conversation

@kixelated

@kixelated kixelated commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

just check fails on main in _lint: cargo fmt --all --check reports a diff in test/interop/clients/rust/tail.rs, left unformatted by a602360 (#5283).

Approach

Ran cargo fmt --all in the Nix devshell. It only changed that file and only reformatted it, so behavior is unchanged.

Impact

  • None (formatting only).

Alternatives

None.

Follow-ups

Tested head 5ce4fd5759e95cbca14cf19ad11407d234c76b0e: nix develop --command just check passed (exit 0).

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 13, 2026 00:45
@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 41fd59f7-6048-4061-ad3e-5e655515c0f1
📥 Commits

Reviewing files that changed from the base of the PR and between db4e887 and 5ce4fd5.

📒 Files selected for processing (1)
  • test/interop/clients/rust/tail.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T00:46:26.463804Z 5ce4fd5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Formatting-only change to test/interop/clients/rust/tail.rs (verified whitespace-only), fixing the cargo fmt --check lint failure on main.
  • Check and Test pass. Interop fails on pairs unrelated to this change (rust->go unroutable, cpp->c timeout); the scheduled Interop run on main has failed for at least the last five nights with the same and more pairs, and Interop is not a required check.
  • Codex reviewed with no findings. CodeRabbit was rate-limited.

Enqueuing with auto-merge pinned to 5ce4fd5759e95cbca14cf19ad11407d234c76b0e.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 418e942 Oct 13, 2026
3 of 4 checks passed
@kixelated
kixelated deleted the chore/rustfmt-interop-tail branch October 13, 2026 01:01
kixelated added a commit that referenced this pull request Oct 13, 2026
#5377 reindented tail.rs with tabs, but no rustfmt config covers
test/interop, so `cargo fmt --all --check` wants rustfmt's default
spaces and fails for every Rust change. This restores the file as it
was before #5377.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant