Skip to content

fix(interop): give the Rust interop clients the repo rustfmt config - #5381

Merged
kixelated merged 1 commit into
mainfrom
fix/interop-rustfmt-config
Oct 13, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/interop-rustfmt-config

Conversation

@kixelated

@kixelated kixelated commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

test/interop/clients/rust/tail.rs has no stable format. The file is a moq-cli bin but lives outside rs/. rustfmt only searches for a config in the file's own directories, so it never finds rs/.rustfmt.toml. Different runs format the file differently, so it keeps changing: #5377 used tabs, and #5068 switched back to spaces. Any PR that runs the full cargo fmt --all --check while main has the other style fails Check.

Approach

Add test/interop/.rustfmt.toml with the same settings as rs/.rustfmt.toml, and run cargo fmt on the file once.

Impact

  • None. This only changes formatting and adds a config file.

Alternatives

  • Revert to rustfmt's defaults. That would leave one Rust file in the repo with a different style.
  • Move tail.rs under rs/moq-cli. It is an interop client, and test/interop owns it.

Follow-ups

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ad79494c-c40c-4480-97ad-5e9efb3a132c
📥 Commits

Reviewing files that changed from the base of the PR and between c5b1150 and 926f4b1.

📒 Files selected for processing (2)
  • test/interop/.rustfmt.toml
  • test/interop/clients/rust/tail.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T01:25:23.993202Z 8de7e89 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: adds test/interop/.rustfmt.toml matching rs/.rustfmt.toml (hard tabs, width 120) and reformats tail.rs once. This unblocks cargo fmt --all --check on main. It supersedes #5383, which is now closed. Config and formatting only, so the change is trivial; Check and Test are green.

(Written by Claude Opus 5.5)

rustfmt only searches for a config above the file, so the tail client under
test/ was formatted with defaults or rs/ settings depending on who ran it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated force-pushed the fix/interop-rustfmt-config branch from 8de7e89 to 926f4b1 Compare October 13, 2026 02:38
@kixelated
kixelated added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 951f8ee Oct 13, 2026
3 of 4 checks passed
@kixelated
kixelated deleted the fix/interop-rustfmt-config branch October 13, 2026 02:54
@kixelated

Copy link
Copy Markdown
Collaborator Author

The failing Interop job is not required, and it has nothing to do with this formatting change. Every tail case passes. The failures are cross-client rounds (go, c, cpp, python, js) whose subscribers idle out, and they failed the same way on the earlier base. Interop only runs when test/interop changes, so main has probably had this breakage for a while without it showing. It needs its own investigation.

(Written by Claude Opus 5.5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant