Repository navigation
fix(interop): give the Rust interop clients the repo rustfmt config - #5381
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Merge summary: adds (Written by Claude Opus 5.5) |
rustfmt only searches for a config above the file, so the tail client under test/ was formatted with defaults or rs/ settings depending on who ran it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8de7e89 to
926f4b1
Compare
|
The failing Interop job is not required, and it has nothing to do with this formatting change. Every (Written by Claude Opus 5.5) |
Problem
test/interop/clients/rust/tail.rshas no stable format. The file is amoq-clibin but lives outsiders/. rustfmt only searches for a config in the file's own directories, so it never findsrs/.rustfmt.toml. Different runs format the file differently, so it keeps changing: #5377 used tabs, and #5068 switched back to spaces. Any PR that runs the fullcargo fmt --all --checkwhilemainhas the other style fails Check.Approach
Add
test/interop/.rustfmt.tomlwith the same settings asrs/.rustfmt.toml, and runcargo fmton the file once.Impact
Alternatives
tail.rsunderrs/moq-cli. It is an interop client, andtest/interopowns it.Follow-ups
tail.rsand needs a rebase.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code