Skip to content

test(ci): align setup and feature fixtures with current workflows #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kixelated merged 3 commits into from
Oct 22, 2026
Merged

test(ci): align setup and feature fixtures with current workflows #6325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ea66db
test(ci): permit build timings after the Check step
kixelated Oct 22, 2026
82538f4
test(ci): count the bare QUIC driver feature lint
kixelated Oct 22, 2026
edd4dee
test(ci): keep timing uploads after the check
kixelated Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions sh/gh/setup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,16 @@ for (const name of ["check"]) {
const setup = job.steps.slice(scopeIndex + 1);
expect(setup.some((step) => step.uses === "./.github/actions/nix")).toBe(true);
expect(setup.some((step) => step.uses === "./.github/actions/rust-cache")).toBe(true);
expect(setup.at(-1)?.name).toBe(job.name);
for (const step of setup) {
expect(setup.filter((step) => step.run).at(-1)?.name).toBe(job.name);
Comment thread
kixelated marked this conversation as resolved.
Resolved
const checkIndex = setup.findIndex((step) => step.name === job.name);
for (const [index, step] of setup.entries()) {
if (step.uses?.startsWith("actions/upload-artifact@")) {
expect(index).toBeGreaterThan(checkIndex);
expect(step.if?.replace(/^\$\{\{\s*|\s*\}\}$/g, "")).toBe(
"!cancelled() && steps.scope.outputs.rust == 'true'",
);
continue;
}
const output = step.uses === "./.github/actions/rust-cache" ? "rust" : "needed";
const hosted = step.uses === "./.github/actions/nix" ? " && runner.environment != 'self-hosted'" : "";
expect(step.if).toBe(`steps.scope.outputs.${output} == 'true'${hosted}`);
Expand Down
4 changes: 2 additions & 2 deletions sh/rs/select.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ def trace(self, owner, *args):
def test_tokio_keeps_extremes_and_crypto_contracts(self):
boundary = self.trace("tokio")
exhaustive = self.trace("tokio", "--all")
self.assertEqual(sum(call.startswith("clippy ") for call in boundary), 2)
self.assertEqual(sum(call.startswith("clippy ") for call in exhaustive), 10)
self.assertEqual(sum(call.startswith("clippy ") for call in boundary), 3)
self.assertEqual(sum(call.startswith("clippy ") for call in exhaustive), 12)
self.assertEqual([call for call in boundary if not call.startswith("clippy ")],
[call for call in exhaustive if not call.startswith("clippy ")])

Expand Down
Loading