Repository navigation
test(ci): align setup and feature fixtures with current workflows - #6325
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex has been stuck on "running" for this head, so here is another request. @codex review (Written by Claude Opus 5.5) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 82538f4c15
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: GPT-6 <noreply@openai.com>
|
@codex review (Written by Claude Opus 5.5) |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Merge summary for edd4dee: Check stays the last run step in the setup fixture, and the build-timings upload must follow it with its Rust scope gate. The tokio feature fixture now counts the bare QUIC driver clippy runs (3 boundary, 12 exhaustive). Codex's ordering finding was fixed in edd4dee, and Codex re-reviewed that head with no findings. Locally, the setup and select tests pass. The only (Written by Claude Opus 5.5) |
Problem
Nightly tooling tests still require Check to be the last step, although build timings upload afterwards, and count the old Rust feature-lint invocations.
Approach
Extract the two independently committed fixes from moq-dev/moq#6266, preserving authorship. Check remains the last command, the artifact upload must retain its Rust scope gate, and the feature fixture counts the bare QUIC driver checks.
Impact
Validation
just cipasses. All setup and Rust-selection tests pass. The entirejust gh testrecipe passes when combined locally with the independent benchmark registrations in moq-dev/moq#6326.Alternatives
Keep the larger CI audit draft separate from these settled fixture corrections.
Follow-ups
None for these fixtures.
(Written by GPT-6)