[kixelated]

Problem

Nightly still selects the removed archive writer target and omits the compression benchmark. The benchmark-coverage tests detect both gaps. Registering compression alone would also fail report parsing because its bundle-size footer is not CSV.

Approach

Extract the archive producer target fix from moq-dev/moq#6266, preserving attribution. Register the compression sweep and emit timing, memory, and bundle-size measurements in reportable CSV. Recognize explicit size_bytes measurements while preserving existing byte input dimensions and stable series names. The nightly coverage test now also fails on a named --bench target that no selected package declares, since Cargo rejects the whole invocation for one.

Impact

• Public API and wire: none. Internal benchmark CSV changes now have their nightly report consumer.

Validation

• just ci passes, including 2,586 net tests.
• All 8 nightly coverage tests and 9 report tests pass.
• The complete just gh test suite passes when combined with the independent fixture corrections in moq-dev/moq#6325.
• Real compression sweep produces 38 validated report entries across both publisher and reader axes.
• cargo check --locked -p moq-archive --bench producer passes.

Alternatives

Do not loosen coverage assertions or skip the compression size results. Keep the separate setup/feature fixture fixes in moq-dev/moq#6325.

Follow-ups

None for benchmark registration.

(Written by GPT-6)

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 05cf1cfa-7cc7-4927-baab-12d4d49f00c3

📥 Commits

Reviewing files that changed from the base of the PR and between d44813c and 70d7ed1.

📒 Files selected for processing: 6

• bench/README.md
• js/net/bench/compression.ts
• sh/gh/bench-report.py
• sh/gh/bench-report.test.py
• sh/gh/nightly.sh
• sh/gh/nightly.test.py

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-22T19:04:09.434952Z	a190ae4	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[kixelated]

Codex has been stuck on "running" for this head, so here is another request.

@codex review

(Written by Claude Opus 5.5)

[kixelated]

Codex's earlier run on 4d0c487 never finished, and this PR has no review yet. a190ae4 drops the removed archive writer bench target, which made Cargo reject the whole rust-extra nightly invocation. It also adds a coverage assertion for named targets that don't exist.

@codex review

(Written by Claude Opus 5.5)

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a190ae49ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[kixelated]

Merge summary:

• The original commits register the archive producer bench and the JS compression sweep in Nightly. The report parser now accepts size_bytes measurement columns.
• a190ae4 drops the stale --bench writer target, which made Cargo reject the whole rust-extra invocation. The coverage test now fails on any named target that no selected package declares.
• 70d7ed1 updates bench/README.md for the size_bytes columns, per Codex's only finding on a190ae4 (resolved).
• Locally, just check, sh/gh/nightly.test.py, and sh/gh/bench-report.test.py pass, and the quest check is clean. just gh test still stops at sh/gh/setup.test.ts, which also fails on main and is fixed by test(ci): align setup and feature fixtures with current workflows #6325.

(Written by Claude Opus 5.5)