Skip to content

chore(quest): finish the JS parsing backport and the release backports epic - #6343

Merged
kixelated merged 6 commits into
mainfrom
quest/m0/release-backports/parsing
Oct 22, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/m0/release-backports/parsing

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

The last child of the focused release backports epic, the JS input parsing backport moq-dev/moq#6349, merged into release. The epic's own remaining work, reconciling the landed backports, is also done, so this PR finishes both quests.

Release inventory, all on release with green Release RS/Go/JS push runs:

The release-plz PR moq-dev/moq#5879 has been regenerated on that head, and its checks pass. Publishing and version bumps stay with the release owners.

Changes:

  • quest rm deletes quest/m0/release-backports/parsing.md, then the now-childless epic quest/m0/release-backports/README.md and its entry in the m0 Required list.
  • Drops the dangling epic sentence from quest/m0/release-fixed-delay.md.
  • The related QPACK, draining-shutdown, and resubscribe quests keep their own m0 entries.

Public API and wire impact: none (quest tracking only).

quest check --base origin/main --branch quest/m0/release-backports/parsing passes.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated kixelated changed the title Backport bounded JS certificate and path parsing quest: track landing of the bounded parsing backport Oct 22, 2026
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 16:41
@kixelated

Copy link
Copy Markdown
Collaborator Author

The implementation is complete in #6349 and passed local CI and focused tests. This tracking update keeps the quest open until the release PR actually lands. quest check --base origin/main and just ci passed for this PR. No maintainer design decisions remain in this tracking change.

(written by GPT-6)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-22T20:47:14.599111Z 29a07c1 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e63d1ef2-ee82-4896-ba0a-17462bcf00dd
📥 Commits

Reviewing files that changed from the base of the PR and between 1f5caa7 and 5f98876.

📒 Files selected for processing: 1
  • quest/m0/release-backports/parsing.md

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Walkthrough

The parsing backport document changes its size heading from [S] to [XS]. It replaces proposed reproduction and porting steps with the scope and status of PR #6349, benchmark results, and completed checks. It states that publishing changes are excluded, public APIs and wire formats are unchanged, and release CI and review still gate landing.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 5f988

The PR is a tracking-document update with no identified merge-blocking risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly describes completing the JavaScript parsing backport and the release backports epic.
Description check Passed The description directly explains the quest cleanup, completed release backport, validation results, and scope of the changes.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

kixelated and others added 2 commits October 22, 2026 11:41
#6349 merged into release, so the quest is complete.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title quest: track landing of the bounded parsing backport chore(quest): finish the JS input parsing release backport quest Oct 22, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main and turned this into the PR that finishes the quest: moq-dev/moq#6349 merged into release, so quest rm deleted the parsing quest and its link from the epic README. This deletion is adjacent to the TLS line removed by moq-dev/moq#6344, so main needs merging in again after that PR lands.

(Written by Claude Opus 5.5)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8bdf377b17

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m0/release-backports/README.md Outdated

- [TLS dependencies](/quest/m0/release-backports/tls.md) - release takes the targeted WebPKI fixes already on main
- [JS input parsing](/quest/m0/release-backports/parsing.md) - malformed certificates and paths cannot trigger disproportionate parsing work
- [FFI cancellation](/quest/m0/release-backports/ffi-cancellation.md) - cancelled reads and accepts leave the next event for the next caller

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the parsing backport quest until it lands

The commit description says PR #6349 is only ready for review and explicitly identifies landing it as the remaining action, but this deletion removes the backport from the epic's required work and erases its quest entirely. Until the release branch actually contains the fix, release reconciliation can now incorrectly proceed without the bounded parsing changes; retain and update the quest to track landing, then delete it after the merge.

AGENTS.md reference: AGENTS.md:L47-L47

Useful? React with 👍 / 👎.

kixelated and others added 2 commits October 22, 2026 13:46
# Conflicts:
#	quest/m0/release-backports/README.md
All three children landed on release (#6347, #6349, #6355) with
green release CI, and the release-plz PR carries them, so the epic's
reconciliation work is done.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title chore(quest): finish the JS input parsing release backport quest chore(quest): finish the JS parsing backport and the release backports epic Oct 22, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main after moq-dev/moq#6344 and moq-dev/moq#6345 landed, which left the release backports epic with no children. All three backports are on release with green release CI, and the release-plz PR moq-dev/moq#5879 carries them with passing checks. That covered the epic's own reconciliation work, so quest rm deleted it too. I also removed the now-dangling epic sentence from the fixed-delay quest. quest check passes.

(Written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge October 22, 2026 20:47
@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit b8bb673 Oct 22, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/release-backports/parsing branch October 22, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant