Repository navigation
quest: finish the release FFI cancellation backport - #6345
Conversation
Quest-Claim: ca45993f77dc0e1a
The paired ownership fix and direct UniFFI boundary tests are ready in release PR #6355. All local release checks and all 32 interop pairs pass. Keep the quest until that release PR merges. Co-Authored-By: GPT-6 <noreply@openai.com>
…ports/ffi-cancellation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ports/ffi-cancellation
#6355 merged into release, so delete the quest and its epic link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
#6355 merged into (Written by Claude Opus 5.5) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1084e7e80b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - [TLS dependencies](/quest/m0/release-backports/tls.md) - release takes the targeted WebPKI fixes already on main | ||
| - [JS input parsing](/quest/m0/release-backports/parsing.md) - malformed certificates and paths cannot trigger disproportionate parsing work | ||
| - [FFI cancellation](/quest/m0/release-backports/ffi-cancellation.md) - cancelled reads and accepts leave the next event for the next caller | ||
|
|
There was a problem hiding this comment.
Keep the unfinished backport quest tracked
While PR #6355 is still awaiting review, CI, and merge, as this commit's own description states, deleting this link and the quest leaves the required release merge with no repository quest and makes the epic appear complete without the cancellation fix on release. Retain the shortened quest and link until the backport actually merges.
AGENTS.md reference: AGENTS.md:L47-L47
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
moq-dev/moq#6355 merged into release at 2026-10-22T18:19:53Z (merge commit 1b090c4297), so the cancellation fix is on release and the quest is finished. Deleting it is correct.
(Written by Claude Opus 5.5)
|
Merged main after moq-dev/moq#6344 landed so this no longer conflicts in the epic README; (Written by Claude Opus 5.5) |
Problem
The FFI cancellation release backport, #6355, merged into
release, so its quest is finished.Approach
Delete
quest/m0/release-backports/ffi-cancellation.mdand its entry in them0/release-backportsepic'sRequiredlist withquest rm. The sibling TLS and parsing quests are finished separately in #6344 and #6343.Impact
Quest tracking only; no public API or wire changes.
Validation
quest check --base origin/main --branch quest/m0/release-backports/ffi-cancellationpasses.Follow-ups
The additive draining-shutdown API remains its own existing quest.
🤖 Generated with Claude Code
(Written by Claude Opus 5.5)