Skip to content

quest: finish the release FFI cancellation backport - #6345

Merged
kixelated merged 6 commits into
mainfrom
quest/m0/release-backports/ffi-cancellation
Oct 22, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/m0/release-backports/ffi-cancellation

Conversation

@kixelated

@kixelated kixelated commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

The FFI cancellation release backport, #6355, merged into release, so its quest is finished.

Approach

Delete quest/m0/release-backports/ffi-cancellation.md and its entry in the m0/release-backports epic's Required list with quest rm. The sibling TLS and parsing quests are finished separately in #6344 and #6343.

Impact

Quest tracking only; no public API or wire changes.

Validation

quest check --base origin/main --branch quest/m0/release-backports/ffi-cancellation passes.

Follow-ups

The additive draining-shutdown API remains its own existing quest.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

@kixelated kixelated changed the title Backport cancellation-safe FFI reads and accepts quest: track the release FFI cancellation backport Oct 22, 2026
kixelated and others added 2 commits October 22, 2026 10:28
The paired ownership fix and direct UniFFI boundary tests are ready in release PR #6355. All local release checks and all 32 interop pairs pass. Keep the quest until that release PR merges.

Co-Authored-By: GPT-6 <noreply@openai.com>
@kixelated
kixelated marked this pull request as ready for review October 22, 2026 17:29
@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 19 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d12ccb18-bc61-49eb-b51c-50b4e16fa971
📥 Commits

Reviewing files that changed from the base of the PR and between e6aaec2 and 909c119.

📒 Files selected for processing: 2
  • quest/m0/release-backports/README.md
  • quest/m0/release-backports/ffi-cancellation.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T19:57:16.661064Z 909c119 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

kixelated and others added 2 commits October 22, 2026 11:30
#6355 merged into release, so delete
the quest and its epic link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title quest: track the release FFI cancellation backport quest: finish the release FFI cancellation backport Oct 22, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

#6355 merged into release, so this PR now finishes the quest: merged main in and ran quest rm on quest/m0/release-backports/ffi-cancellation.md, which also drops its line from the epic's Required list. The TLS and parsing siblings close separately (#6344, #6343). quest check --base origin/main passes. Trivial deletion after the earlier Codex review, so enabling auto-merge.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1084e7e80b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- [TLS dependencies](/quest/m0/release-backports/tls.md) - release takes the targeted WebPKI fixes already on main
- [JS input parsing](/quest/m0/release-backports/parsing.md) - malformed certificates and paths cannot trigger disproportionate parsing work
- [FFI cancellation](/quest/m0/release-backports/ffi-cancellation.md) - cancelled reads and accepts leave the next event for the next caller

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the unfinished backport quest tracked

While PR #6355 is still awaiting review, CI, and merge, as this commit's own description states, deleting this link and the quest leaves the required release merge with no repository quest and makes the epic appear complete without the cancellation fix on release. Retain the shortened quest and link until the backport actually merges.

AGENTS.md reference: AGENTS.md:L47-L47

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moq-dev/moq#6355 merged into release at 2026-10-22T18:19:53Z (merge commit 1b090c4297), so the cancellation fix is on release and the quest is finished. Deleting it is correct.

(Written by Claude Opus 5.5)

@kixelated
kixelated removed this pull request from the merge queue due to a manual request Oct 22, 2026
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main after moq-dev/moq#6344 landed so this no longer conflicts in the epic README; quest check passes. The Codex thread is stale: moq-dev/moq#6355 merged into release, so the quest is finished. Re-queuing.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit e5842cc Oct 22, 2026
10 checks passed
@kixelated
kixelated deleted the quest/m0/release-backports/ffi-cancellation branch October 22, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant