Repository navigation
quest: audit the tree and open PRs - #6383
Conversation
Factual corrections from a full quest audit: drop landed work and dead references, fix moved paths, add missing Required/Related links, and move Drop web-transport-trait above the Perf epic that requires it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fold export reorder into decode order (marked for re-planning), split the OBS decode timing fix into m1, the hang draft warmup amendment and the fMP4 ambisonic layout into their own quests, and record the ordering, ownership, and scope decisions from the audit interview. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # quest/m1/public-model/answer.md # quest/m1/release-audit/README.md # quest/m2/intra-refresh/README.md # quest/m2/intra-refresh/plan-boundary.md
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 15 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfeb22bedf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Peer count bounds links the session-limits quest that keeps or drops the per-session caps, and the TS program cap waits for pat-lifecycle, which rewrites programs.rs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 842e43e23b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ebb0a9c3bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Main finished or replanned binding-trim, largest-getter, stats-naming, peer-count-bounds, public-model/answer, refresh, sparse-gaps, sync-wait, ietf-subscribe-pause, warmup-draft, cmaf-counts, and export-reorder, so links this PR added to them now point at what landed or at decode-order. Applies the Codex review: recurring audits stop naming m2 to m3, the OBS EOF drain loops until AVERROR_EOF, and the qmux profiler is an example binary rather than a Cargo bench target that Nightly would report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # quest/m1/api-audit/auth-clock-names.md # quest/m1/api-audit/decode-read.md # quest/m2/README.md # quest/m2/performance-survey/README.md
Take main's plan where it finished or moved quests, and reapply only the audit's own edits: JS handover landed (#5836), moq-auth in the transport-config break list, the OBS decode timing child, qmux already off the web-transport-trait adapter, and links to the release-audit fixes main merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main finished ranges-wire, wrapper-config, shared-parser, hls-admission, auth-listeners, and rate-recovery; drop this audit's lines for them and keep its OBS decode timing, derived-origin, and program-cap edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Main finished broadcast-epoch, program-cap, and decode-order, and moved drop-web-transport-trait to m1. Drops this branch's edits to the finished quests, keeps its m0 Goal trim (without the CONNECT-header bound, landed in #6601), the Route::auth keep in main's rewritten net-exports, and the OBS decode timing child in release-audit, and retargets decode-order links to #6453. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
A full audit of the quest tree on main (524 quests) and every open PR (97), split across seven read-only reviewers. This PR applies the factual corrections and the maintainer's decisions to the tree on main. PR-side fixes were pushed to their own branches separately.
Factual corrections
Demand::used/unusedand padding lines, lite-07 finalize's landed Required items, ts-reliability's PSI runs and linger, test-flakes-2's deleted child, the m0 DoS-review pointer, broadcast-epoch's JS handover and IETF extension, the lite "offset by 1" fix, and the release-audit PR links in performance-survey (now quest links).transport::pollin drop-web-transport-trait and broadcast-fairness, the plan-boundary rounding, the 2026-10-22 decision in read-backfill, the audit-dead-code baseline, and perf'sjust bench-runtimerule.audit-deps.md) was wrong in all six.Decisions (2026-10-22, maintainer)
Route::{auth, with_auth}public (net-exports), since auth/issuer consumes it. (Alternative: make them pub(crate).)Encodingenum and requires compress/migrate. (Alternative: keep both.) stats-naming has since landed (moq-dev/moq#6472).release-audit/obs-decode-timing.md, instead of waiting for the m2 replacement. Its EOF drain loopsavcodec_receive_frameuntilAVERROR_EOF. (Alternative: accept them until m2.)mux-vr-ambisonic-fmp4.md, which alone requires cmaf-opus-surround. (Alternative: keep the Required.)Encoder::encodeseam. (Alternative: split the seam out.)rs/qmux/examples, not a Cargo bench target, since Nightly runs and reports every bench target. (Alternative: stream/bench.)releasenow. (Alternative: move them beside the cut.)Follow-ups from merged PRs
program-caprequires pat-lifecycle, which rewrites the sameprograms.rs.Merged with main (2026-10-23)
Main finished binding-trim, largest-getter, stats-naming, peer-count-bounds, refresh, sparse-gaps, sync-wait, ietf-subscribe-pause, warmup-draft, and cmaf-counts, and moq-dev/moq#6581 retired public-model/answer. This PR's edits to those files are dropped, and links it added to them (av-clock's sync-wait Required, resolved-demand's sparse-gaps link) are removed.
Merged with main (2026-10-24)
Main finished ranges-wire, wrapper-config, shared-parser, hls-admission, auth-listeners, rate-recovery, cli-flags, and the QPACK fix. This PR's lines for them are dropped; its OBS decode timing entry, derived-origin wording, and program-cap's pat-lifecycle Required are kept.
quest checkandjust checkpass on c8fa546.Merged with main (2026-10-24, after the queue drop)
Main finished broadcast-epoch, program-cap, and decode-order (moq-dev/moq#6453), rewrote net-exports, and moved drop-web-transport-trait to m1 (moq-dev/moq#6611). This PR's edits to the finished quests are dropped; the m0 Goal trim stays, without the bounded CONNECT headers (moq-dev/moq#6601 landed them); the
Route::{auth, with_auth}keep moves into net-exports' "Kept" note; the OBS decode timing child returns as release-audit's only Required entry (the OBS source still drops reordered timestamps and EOF output on main); the m2 ranking edit for drop-web-transport-trait falls away, and its qmux wording moves to the m1 README entry; decode-order links now cite #6453.quest checkandjust checkpass on 198d5b2.Public API / wire impact
None. This PR changes quest files only.
(Written by Claude Opus 5.5)
🤖 Generated with Claude Code