Repository navigation
fix(nix): keep crane's kio manifest in the dependency stage - #6586
Conversation
Since rs/kio inherits workspace lints, copying its real manifest into crane's dummy tree fails every package build: the dummy root manifest drops `workspace.lints`. Restore only kio's sources. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
Since moq-dev/moq#6159,
rs/kio/Cargo.tomlinherits[lints] workspace = true. The crane overlay copies kio's real directory, manifest included, into the dependency-only dummy tree, whose cleaned root manifest dropsworkspace.lints. Every crane package build on main now fails before compiling:Reproduced with
nix build .#moq-relayon main and insidedocker build --build-arg package=moq-relay .. This breaks the Docker images, release artifacts, and anything else built throughbuildPackage. Nightly has not run since #6159 merged, so its Docker dry-run has not caught it yet.Approach
Restore only kio's
src/into the dummy tree and keep crane's cleaned kio manifest. The registry crates patched onto kio only need its real API.kioSourcenarrows tors/kio/srcto match.Impact
nix build .#<package>and the rootDockerfile, including moq-dev/moq#6257's source-built relay image.Validation
nix build .#moq-relay: fails on main, passes here (kio compiles with its real source in the dependency stage).nixfmt --check nix/overlay.nix: passes.just check: itscheck flakemodule fails locally only on the github-runner VM image, which needs user namespaces this host does not grant (unshare: write failed /proc/self/uid_map); unrelated to this change.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)