Skip to content

fix(nix): keep crane's kio manifest in the dependency stage - #6586

Merged
kixelated merged 1 commit into
mainfrom
fix/kio-dummy-lints
Oct 23, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/kio-dummy-lints

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

Since moq-dev/moq#6159, rs/kio/Cargo.toml inherits [lints] workspace = true. The crane overlay copies kio's real directory, manifest included, into the dependency-only dummy tree, whose cleaned root manifest drops workspace.lints. Every crane package build on main now fails before compiling:

error inheriting `lints` from workspace root manifest's `workspace.lints`
  `workspace.lints` was not defined

Reproduced with nix build .#moq-relay on main and inside docker build --build-arg package=moq-relay .. This breaks the Docker images, release artifacts, and anything else built through buildPackage. Nightly has not run since #6159 merged, so its Docker dry-run has not caught it yet.

Approach

Restore only kio's src/ into the dummy tree and keep crane's cleaned kio manifest. The registry crates patched onto kio only need its real API. kioSource narrows to rs/kio/src to match.

Impact

  • Public API: none.
  • Wire: none.
  • Consumer: every nix build .#<package> and the root Dockerfile, including moq-dev/moq#6257's source-built relay image.

Validation

  • nix build .#moq-relay: fails on main, passes here (kio compiles with its real source in the dependency stage).
  • nixfmt --check nix/overlay.nix: passes.
  • just check: its check flake module fails locally only on the github-runner VM image, which needs user namespaces this host does not grant (unshare: write failed /proc/self/uid_map); unrelated to this change.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Since rs/kio inherits workspace lints, copying its real manifest into
crane's dummy tree fails every package build: the dummy root manifest
drops `workspace.lints`. Restore only kio's sources.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9563a448-4bb1-40b7-85d5-bbc17b4db0e8
📥 Commits

Reviewing files that changed from the base of the PR and between 2f146e8 and 63c6091.

📒 Files selected for processing: 1
  • nix/overlay.nix
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T20:57:44.852027Z 63c6091 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated
kixelated merged commit 0cccbd8 into main Oct 23, 2026
9 checks passed
@kixelated
kixelated deleted the fix/kio-dummy-lints branch October 23, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant