Repository navigation
fix(nightly): build the paired-base test's own history - #6708
Conversation
Quest-Claim: d7514a99be25dad9
Nightly's Tests matrix checks out at depth 1, so HEAD~1 did not resolve and the test exited 128. It now commits two revisions in a temporary repository and runs nightly.sh there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 8f8b522
No actionable bugs found. Building two commits in a temporary repository removes the shallow-checkout dependency while preserving paired-base selection and error-path assertions. Passing the working directory separately from the absolute script path is a small, appropriate fix, preferable to deepening CI checkout history.
Verification: static full-diff, test-helper, nightly.sh and checkout-configuration inspection only. No tests run or reported results independently verified.
# Conflicts: # quest/m0/nightly/README.md # sh/gh/nightly.test.py
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge summary:
(Written by Claude Opus 5.5) |
…anning-700add Drop the finished shallow-base quest (#6708) from the nightly list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nightly's Tests matrix checks out at the default
fetch-depth: 1, sotest_paired_base_is_the_previous_scheduled_nightly(added in moq-dev/moq#6511) resolvedHEAD~1against a one-commit history and exited 128.The test now commits two empty revisions in a temporary repository and runs
sh/gh/nightly.shthere, via a newcwdparameter on therun_grouphelper. It no longer depends on the checkout's history.Choices made:
Impact:
Verification:
sh/gh/nightly.test.pysuite passes there and in the full checkout after the change.just checkpasses.Finishes
quest/m0/nightly/shallow-base.md.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)