Skip to content

fix(nightly): build the paired-base test's own history - #6708

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/nightly/shallow-base
Oct 25, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/nightly/shallow-base

Conversation

@kixelated

@kixelated kixelated commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Nightly's Tests matrix checks out at the default fetch-depth: 1, so test_paired_base_is_the_previous_scheduled_nightly (added in moq-dev/moq#6511) resolved HEAD~1 against a one-commit history and exited 128.

The test now commits two empty revisions in a temporary repository and runs sh/gh/nightly.sh there, via a new cwd parameter on the run_group helper. It no longer depends on the checkout's history.

Choices made:

  • Fixed the test rather than deepening the Nightly checkout, per the quest plan: the test should not depend on how CI clones.

Impact:

  • Public API: none. Wire: none.

Verification:

  • Reproduced the exit 128 in a depth-1 clone of this branch; the full sh/gh/nightly.test.py suite passes there and in the full checkout after the change.
  • just check passes.

Finishes quest/m0/nightly/shallow-base.md.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

kixelated and others added 2 commits October 24, 2026 22:39
Nightly's Tests matrix checks out at depth 1, so HEAD~1 did not resolve and
the test exited 128. It now commits two revisions in a temporary repository
and runs nightly.sh there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated marked this pull request as ready for review October 25, 2026 05:42
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 01768b5c-5675-4805-be37-60c19120d40d
Commits

Reviewing files that changed from the base of the PR and between 17be545 and dd331e0.

Files selected for processing: 3
  • quest/m0/nightly/README.md
  • quest/m0/nightly/shallow-base.md
  • sh/gh/nightly.test.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated kixelated changed the title Nightly's base in a shallow checkout fix(nightly): build the paired-base test's own history Oct 25, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T22:33:12.897622Z dd331e0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 8f8b522

No actionable bugs found. Building two commits in a temporary repository removes the shallow-checkout dependency while preserving paired-base selection and error-path assertions. Passing the working directory separately from the absolute script path is a small, appropriate fix, preferable to deepening CI checkout history.

Verification: static full-diff, test-helper, nightly.sh and checkout-configuration inspection only. No tests run or reported results independently verified.

kixelated and others added 2 commits October 25, 2026 15:31
# Conflicts:
#	quest/m0/nightly/README.md
#	sh/gh/nightly.test.py
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary:

  • Merged origin/main to resolve conflicts. sh/gh/nightly.test.py: kept this PR's temporary-repository test, adapted to main's MOQ_BENCH_BASE -> BENCH_BASE rename. quest/m0/nightly/README.md: shallow-base was the epic's last child, so the Required section is gone.
  • With no children left, the epic now carries a size ([S]) so quest check passes; its README holds the remaining work (keep-going multi-step jobs, confirming a scheduled run passes).
  • Verified sh/gh/nightly.test.py passes (14 tests) in the full checkout and in a depth-1 clone of the merged head. Required checks pass; Codex approved the current head.

(Written by Claude Opus 5.5)

@kixelated
kixelated added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit 9499dc0 Oct 25, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/nightly/shallow-base branch October 25, 2026 23:42
kixelated added a commit that referenced this pull request Oct 25, 2026
…anning-700add

Drop the finished shallow-base quest (#6708) from the nightly list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant