[kixelated]

Problem

moq-net and @moq/net names collided with other items (stats::Control vs track::Control, stats::Bytes vs bytes::Bytes, transport::Stats vs session::Stats, JS Reservation.grant vs Auth.Grant, and a reservation's rate named peek() in Rust, grant() in the bindings, and rate in JS), described the wrong shape (Session::bandwidth() returns an allocator beside the send_bandwidth()/recv_bandwidth() estimates), or did not mirror each other (Rust query() vs JS info(), JS writeGroup vs Rust create_group). Quest: quest/m1/api-audit/net-names.md.

Approach

One commit per decided rename, each carried through every caller, binding, and doc that exposes it. transport::Metrics drops the byte counts, and session::Stats reads them from the transport's Wire.

Impact

All breaking; rs/moq-net, js/net, rs/moq-tokio, rs/moq-ffi, rs/moq-c, and each wrapper's MIGRATE.md say how to migrate. Wire: none.

• moq-net: Session::bandwidth() → allocator(), Client::with_bandwidth → with_allocator, auth::Auth → auth::Credential, track::Consumer::query()/track::Querying → info()/track::Resolving, bandwidth::Reservation::consumer() → consume(), bandwidth::Reservation::peek() → rate(), stats::Control → stats::Message, stats::Bytes → stats::Totals.
• moq-net: group::Demand drops is_used/used/unused/poll_used/poll_unused for wanted(), wanted_changed(), and poll_wanted_changed(), like track::Demand.
• moq-net: transport::Stats → transport::Metrics without bytes_sent/bytes_received; poll::Session::stats() → metrics(), now defaulted; transport::StatsUnavailable is gone.
• moq-tokio: Connection::bandwidth() → allocator().
• @moq/net: Auth.Auth → Auth.Credential, Reservation.grant → rate, a connection's bandwidth → allocator, and Track.Producer.writeGroup(group) → createGroup(sequence), which returns the new group.
• moq-ffi: MoqBandwidth → MoqAllocator and MoqSession::bandwidth() → allocator(); each wrapper's Bandwidth/bandwidth() → Allocator/allocator(). MoqReservation::grant() → rate(), and each wrapper's Reservation.grant() (Go Grant()) → rate() (Go Rate()). Python's and Swift's nested Bandwidth.Consumer is now the top-level BandwidthConsumer, as in Kotlin, Dart, and C++. Producer options keep their bandwidth field, like moq-audio/moq-video.
• moq-c: moq_session_bandwidth → moq_session_allocator, moq_bandwidth_reserve → moq_allocator_reserve, moq_bandwidth_close → moq_allocator_close, moq_reservation_grant → moq_reservation_rate. The C ABI is not frozen: its Unreleased MIGRATE already carries layout-breaking changes. The receive-estimate names (recv_bandwidth, moq_bandwidth_consumer_*) stay.

Choices made without asking, for review:

• poll::Session::stats() is also renamed metrics(), so the method names what it returns.
• moq-tokio sessions over a backend without wire counters (Iroh) keep a wire that metrics() refreshes from the backend's byte stats, so Iroh still reports bytes; the registry sees them only once something samples the session.
• JS createGroup takes a sequence and builds the group like Rust's create_group and @moq/e2ee's createGroup, rather than only renaming writeGroup(group). So a group can no longer be written before joining a track, or join two tracks; the three tests for that path are gone, and so is the groupStart hook.
• JS's connection bandwidth became allocator too, since it has the same collision beside probe.

Alternatives

• Rename writeGroup to createGroup(group) only: keeps prefilled and shared groups, but createGroup would then take two shapes within JS.
• Drop Iroh's session byte counts, not add a polled wire: simpler, but a regression.

Decisions

• What do Rust, the bindings, and the C ABI call a reservation's current slice? (JS calls the watchable signal rate, read with rate.peek().)

  • peek() / moq_reservation_peek, matching Rust before this PR (recommended at the time)
  • rate() / moq_reservation_rate, matching JS's rate ✅ (maintainer, 2026-10-25)
  • keep grant() in the bindings

  JS keeps its signal-free Reservation.peek(), which reads the registry directly after a synchronous update(), beside the rate signal.

Merging main: moq-dev/moq#6428 dropped the JS per-name sequence namespace, so its replacement tests resolve to main's "a replacement producer starts over", now written with createGroup. The later merge renames main's new track::Consumer::query() callers (lite and IETF publishers, the fuzz bench helper) to info() and its new auth::Auth uses to Credential, keeps both sides' MIGRATE entries, fixes the Python and Swift docs that still named Bandwidth.Consumer, and regenerates the Dart bindings and @moq/net API report. The third renames the configured-token code from moq-dev/moq#6177 (moq-tokio's auth::Auth and @moq/net's Auth, which connection/tokens.ts imports as Presented beside its own internal dial Credential) and carries the renames into the merged binding docs. The fourth keeps main's now-used InFlight::accepted beside this branch's track::Resolving, keeps both moq-tokio MIGRATE entries, and drops main's new quest/m1/api-audit/wanted.md blocker on this one, noting that group::Demand already says wanted. The fifth keeps both sides' Unreleased MIGRATE entries beside moq-dev/moq#6745's decoder reads, the sixth takes moq-dev/moq#6851's async-only lint reason on stats::Session::control with stats::Message, and the seventh regenerates the @moq/net report under moq-dev/moq#6794's API Extractor and carries the Session allocator entry into the hand-written 0.7 history that moq-dev/moq#6052's generated c/moq/MIGRATE.md copies. The eighth carries the renames into moq-dev/moq#6781's simulcast rungs (MoqAllocator option types, Reservation::rate()/consume(), moq_allocator_* in the C tests, main's new query() and JS writeGroup callers), keeping its idle-reservation MIGRATE entries in the new names. The ninth merges moq-dev/moq#6750: finish()/abort() with createGroup(), dropping its shared-group and prefilled-group tests that createGroup rules out, and one hole-fill test now awaits the group's asynchronous finish. The tenth takes moq-dev/moq#6834, which replaced the per-token binding handles (MoqAuth, MoqAuthToken, each wrapper's Auth/AuthToken) with MoqSession.tokens()/grants(), so the binding-level Credential rename and its MIGRATE entries are gone; moq-net's auth::Auth is still renamed Credential, including the session fields #6834 added.

Checks: just check (all lanes the branch touches, including 8868 Rust tests; on the bindings commit, dart's RSS-bounded leak_test.dart failed once under the parallel load and passes alone), just rs wasm, just test interop --all, and bun test in net, hang, watch, e2ee, publish, and room all pass. After the rate() rename and merging main: just check (js, rs with 8865 tests, markdown, gh, quest, obs, drill, lints) plus just py check/test, kt check (the Kotlin wrapper build and JVM tests), go check, cpp check, obs compile, and dart check pass. Not run: the Swift wrapper (no macOS here). After the latest merge of main: just check passes every lane it selects (rs, js, py, kt, swift, go, cpp, obs, dart, markdown, quest, and the rest). just rs features and just rs loom fail on errors this PR does not touch, which origin/main has too: moq-net's rustdoc links (crate::Session::closed, Self::unused in track/fill.rs, and three private-item links), moq-tokio's open_request unused in one tokio-features combination, and tests/loom.rs calling the now-private Broadcast::route() and the removed Subscription::with_groups. The rest of features (quic, media, --no-default-features) passes. After the fourth through sixth merges of main: just check passes every lane it selects (rs, js, py, kt, go, cpp, obs, dart, markdown, quest, and the rest; Swift skips without a toolchain here) after each, and just test interop --all passes after the fifth. After the seventh: just check passes every lane it selects (rs with 9068 tests, c, cpp, js, py, kt, go, obs, dart, markdown, gh, quest, toml, nix, and the rest; Swift skips without a toolchain), and so does just test interop --all.

After the eighth through tenth merges: just check passes every lane it selects (rs, c, cpp, obs, js, py, kt, go, dart, markdown, gh, quest, toml, nix, and the rest; Swift skips without a toolchain), and so does just test interop --all.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-27T08:09:17.460268Z	133c1a5	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[kixelated]

Automated review by review (OpenAI)

Reviewed commit: 284515e

No actionable bugs found in the inspected changes. Consistent names and the narrower JS createGroup ownership API are a coherent direction. Rust allocator/credential/info/stats callers, binding credential wrappers, group demand watchers and transport Wire/metrics snapshot handling remain aligned through the migration.

Verification: static GitHub inspection of the changes and relevant surrounding code only. No builds, binding regeneration, tests or interoperability checks executed.

[kixelated]

Automated review by review (OpenAI)

Reviewed commit: 59da867
Compared with previous review at 284515e.

No actionable bugs found in this update. Extending Allocator naming through UniFFI, language wrappers, OBS and the C ABI keeps the public surface aligned. The Python/Swift BandwidthConsumer move and retained producer bandwidth options are documented. Inspected caller migrations, Dart native symbols/converters and C++ binding generation.

Verification: static GitHub inspection only; no builds, binding regeneration or tests executed.

[kixelated]

Merged main again after moq-dev/moq#6750 and moq-dev/moq#6834 landed, then landing 133c1a595183b46ae94a7122c19a42186cfc439a.

• moq-dev/moq#6781: its simulcast-rung code now uses MoqAllocator, Reservation::rate()/consume(), and moq_allocator_*; its idle-reservation MIGRATE entries are kept, in the new names.
• moq-dev/moq#6750: finish()/abort() combined with createGroup(). Its shared-group and prefilled-group tests are dropped, since createGroup rules both out, and one hole-fill test now awaits the group's asynchronous finish.
• moq-dev/moq#6834 deleted the per-token binding handles (MoqAuthToken and each wrapper's AuthToken), so the binding-level Credential rename and its MIGRATE entries are gone. moq-net's auth::Auth is still renamed Credential, including the session fields feat(auth)!: per-connection tokens with an answer, and a grant consumer #6834 added.

Checks: just check passes every selected lane, Swift excepted (no toolchain here). just test interop --all passes, and so does quest check.

(Written by Claude Opus 5.5)