Repository navigation
quest: move the route prototype into m1 - #8528
Conversation
quest start refuses it under the routes epic, which waits on m1 quests it needs nothing from. It changes tests only, and the m1 model quests wait on its outcome. Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — checked the whole quest-only diff on 3c07153, including the naming, dependency, and contract consistency around the move.
- Prototype moved into m1 —
quest/m2/cluster-routing/routes/stale-copies.mdis renamed toquest/m1/route-stale-copies.md, so the quest no longer inherits the routes epic's and m2's blockers.quest/m1/and its README carry noRequired, so the quest starts clean, and its Plan records why. - Inbound links rewritten — the ten links to the prototype across seven files now point at the new path:
quest/m2/cache-routing-proof.md,quest/m2/cluster-routing/README.md,quest/m2/cluster-routing/routes/README.md(decision 26),scope-model.md,scope.md,quest/m3/cache-routing/README.md, andquest/m3/route-keep-next-hop.md. - Revision rule clarified —
scope-model.mdandscope.mdnow say the revision governing a claim is the newest one a covering route gave it, and a newer revision from a route that does not cover the claim says nothing about it.
Verification: grep -rn stale-copies quest/ leaves only the new path, and no skill or draft names the old one. The epic's Required lists only route-mesh-model.md and m1's README has no child index, so neither needs an edit. The clarified rule matches the epic contract ("whichever view covers the claim with the newer floor decides", plus the lagging-certifier bullet) and drafts/draft-lcurley-moq-lite.md line 458 ("of the streams whose floor certifies the claim, the one with the highest Revision decides"). Dependency order after the move is acyclic: scope-model requires the prototype, and route-inductive / route-trace-validation require scope-model. PR #8533 has since opened with head quest/m1/route-stale-copies, which confirms the move unblocked quest start at the new path.
deepseek-v4.1-flash-1017 (free via Pullfrog for OSS) ｜ 𝕏
Problem
quest startrefusesquest/m2/cluster-routing/routes/stale-copies.md, the prototype that settles what keeps a lite-07 route free of loops and stale copies. Nothing it needs is missing:quest/m1/route-mesh-model.md, whose PR moq-dev/moq#8479 is open.quest/m1/drop-set.md(moq-dev/moq#8476, open) andquest/m1/stream-credit/takeover.md.The prototype changes tests only, and two m1 model quests (
route-inductive,route-trace-validation) already wait on the model quest that waits on it.Approach
quest mvmoves it toquest/m1/route-stale-copies.mdand rewrites the seven links to it. Its Plan says why.scope-model.mdandscope.md, the revision that governs a claim is the newest one a covering route gave, since a newer revision from a route that does not cover the claim says nothing about it.Decisions
Impact
None. Quest files only.
Alternatives
See Decisions.
Follow-ups
None.
Checks
quest check --base origin/main: 514 documents ok.quest unblocked quest/m1/route-stale-copies.md: ready.Models
Size: XS
Implementer: Claude Code, claude-fable-5-2, high effort
🤖 Generated with Claude Code
(Written by Claude Fable 5 with high)