Repository navigation
docs(skills): keep /quest-complete current across rounds - #207
Merged
Merged
Conversation
Quest-Claim: 39f0320a6122fcc3
Re-scan open PRs whenever a sub-agent reports or a merge wait wakes, keep skips and holds until the user lifts them, and never treat a blanket "accept all" as a merge pick. Count design-checkpoint review rounds from the PR's history since its last `Design change:` comment, so re-dispatched sub-agents still reach it, and apply the checkpoint in iterate too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
marked this pull request as ready for review
October 24, 2026 06:08
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Resolved the helpers epic's Required list by hand: both sides deleted their finished quest (complete-loop here, merge-rules on main), so both lines go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
Merge summary
Suggested follow-ups (from the PR body) are left for (Written by Claude Opus 5.5) |
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes quest/m0/helpers/complete-loop.md, as planned on 2026-10-21 from the month of moq maintainer transcripts.
Problem
/quest-completeonly refreshed the PR list before finishing, so the maintainer kept asking "any new PRs?". A blanket "accept all" could be read as merge approval, skips and holds were lost when sub-agents were re-dispatched, and every fresh merge sub-agent counted review rounds from zero, so the design checkpoint never fired.Changes
complete: refresh the open PR list whenever a sub-agent reports or a merge wait wakes (and once more before finishing), asking about new PRs the same way. A blanket answer such as "accept all" or "use your recommendations" never picks/quest-merge. A skip or hold stands until the user lifts it and goes into every sub-agent brief for that PR.merge: a review round is one pushed head that drew reviews, counted from the PR's history since its last design change rather than from the session. Each design change, including a rethink the user picks, is recorded in a PR comment that starts withDesign change:, which the next agent counts from.iterate: applies the same checkpoint, which it lacked.Requiredentry and the ranking note instatus-holds.md).Choices made without asking
Design change:. This mirrors the## Decisions neededconvention, so later agents can find it with a plain text search.quest statuslists only each reviewer's latest review, so the skills read the full history withgh pr view <pr> --json reviews,comments. I did not add a round count toquest status, which would go beyond this prose-only quest.mergeanditerate(about three lines are repeated). It could live once in the guide's Reviews section, butassets/AGENTS.mdwas outside the edits this plan authorized.Validation
just checkandjust testpass locally (333 tests).Suggested follow-ups
merge,iterate, andcompleteshare one definition.quest status(or a flag on it) report the number of review rounds since the lastDesign change:comment, so agents stop counting withgh.(Written by Claude Opus 5.5)
🤖 Generated with Claude Code