Skip to content

docs(skills): keep /quest-complete current across rounds - #207

Merged
kixelated merged 3 commits into
mainfrom
quest/m0/helpers/complete-loop
Oct 24, 2026
Merged

kixelated merged 3 commits into
mainfrom
quest/m0/helpers/complete-loop

Conversation

@kixelated

@kixelated kixelated commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m0/helpers/complete-loop.md, as planned on 2026-10-21 from the month of moq maintainer transcripts.

Problem

/quest-complete only refreshed the PR list before finishing, so the maintainer kept asking "any new PRs?". A blanket "accept all" could be read as merge approval, skips and holds were lost when sub-agents were re-dispatched, and every fresh merge sub-agent counted review rounds from zero, so the design checkpoint never fired.

Changes

  • complete: refresh the open PR list whenever a sub-agent reports or a merge wait wakes (and once more before finishing), asking about new PRs the same way. A blanket answer such as "accept all" or "use your recommendations" never picks /quest-merge. A skip or hold stands until the user lifts it and goes into every sub-agent brief for that PR.
  • merge: a review round is one pushed head that drew reviews, counted from the PR's history since its last design change rather than from the session. Each design change, including a rethink the user picks, is recorded in a PR comment that starts with Design change:, which the next agent counts from.
  • iterate: applies the same checkpoint, which it lacked.
  • Deletes the finished quest and its links (the epic's Required entry and the ranking note in status-holds.md).

Choices made without asking

  • Design-change marker: a PR comment that starts with Design change:. This mirrors the ## Decisions needed convention, so later agents can find it with a plain text search.
  • Round history source: quest status lists only each reviewer's latest review, so the skills read the full history with gh pr view <pr> --json reviews,comments. I did not add a round count to quest status, which would go beyond this prose-only quest.
  • Checkpoint location: the checkpoint is now written out in both merge and iterate (about three lines are repeated). It could live once in the guide's Reviews section, but assets/AGENTS.md was outside the edits this plan authorized.

Validation

just check and just test pass locally (333 tests).

Suggested follow-ups

  • Move the design checkpoint into the guide's Reviews section so merge, iterate, and complete share one definition.
  • Have quest status (or a flag on it) report the number of review rounds since the last Design change: comment, so agents stop counting with gh.

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

kixelated and others added 2 commits October 23, 2026 23:03
Re-scan open PRs whenever a sub-agent reports or a merge wait wakes, keep
skips and holds until the user lifts them, and never treat a blanket
"accept all" as a merge pick. Count design-checkpoint review rounds from
the PR's history since its last `Design change:` comment, so re-dispatched
sub-agents still reach it, and apply the checkpoint in iterate too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Keep /quest-complete current across rounds docs(skills): keep /quest-complete current across rounds Oct 24, 2026
@kixelated
kixelated marked this pull request as ready for review October 24, 2026 06:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T15:45:51.693481Z e24ed42 New commits
🔒 Security Review ✅ Completed 2026-10-24T15:50:03.413904Z e24ed42 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Resolved the helpers epic's Required list by hand: both sides deleted their finished quest (complete-loop here, merge-rules on main), so both lines go.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary

  • Merged main into the branch as e24ed42 (no rebase). The helpers epic's Required list conflicted: this PR removed the Complete loop entry and main (kixelated/quest#206) removed the Merge rules entry, both because their quests were finished. I resolved it by hand and kept both removals. The skill edits auto-merged and still agree with main's new Reviews rule and with the namespace rule from kixelated/quest#214.
  • Because I resolved a conflict by hand, the new Reviews rule required a review of the new head. Codex's code review and security review both finished on e24ed42 with no findings. CI passed on that head.
  • Locally, just check and just test passed (340 tests). quest check --base origin/main --branch quest/m0/helpers/complete-loop also passed. I ran it with a quest built from main, outside the head checkout.
  • Main has since gained kixelated/quest#205. It touches only kix files and does not conflict with this PR.
  • Landing as a squash merge, which is the only method this repository allows.

Suggested follow-ups (from the PR body) are left for /quest-plan: define the design checkpoint once in the guide's Reviews section, and have quest status report the number of review rounds since the last Design change: comment.

(Written by Claude Opus 5.5)

@kixelated
kixelated merged commit 82a9566 into main Oct 24, 2026
3 of 4 checks passed
@kixelated
kixelated deleted the quest/m0/helpers/complete-loop branch October 24, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant