Skip to content

docs(complete): a blanket answer picks every recommendation - #262

Merged
kixelated merged 2 commits into
mainfrom
quest-complete/blanket-picks
Oct 28, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest-complete/blanket-picks

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

/quest-complete treated "use your recommendations" as approval for everything except /quest-merge (kixelated/quest#207). That forced a separate question for every merge after the maintainer had already said yes to the whole set. The maintainer wants a blanket answer to be a blank check.

Change

A blanket answer now picks the recommendation for every PR in scope, /quest-merge included. The exception: a PR whose recommendation settles a decision the user hasn't been shown yet, such as a disputed security finding or a stale-hold takeover, still gets its own question. In the session that prompted this change, that exception mattered: the user overrode the recommendation on both PRs that carried security decisions.

Checks

  • Prettier passes.
  • bun run test: 570 passed, 2 failed in test/agent.test.ts. The same 2 fail on main without this change, so they're environment-related.

🤖 Generated with Claude Code

(written by Claude Opus 5.5)

"Use your recommendations" is a blank check, /quest-merge included. Only a
recommendation that settles a decision the user hasn't seen still needs its
own question.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-28T16:57:37.051785Z aab412e New commits
🔒 Security Review ✅ Completed 2026-10-28T16:59:37.772563Z aab412e New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 2432a57

No actionable bugs found. Applying a blanket answer to the presented recommendations removes redundant merge questions while retaining explicit questions for unseen decisions. The surrounding current-session selection, later-refresh, and persistent skip/hold rules keep the scope bounded; a single exception in the existing selection rule is simpler than a separate approval mechanism.

Verification limits: static inspection of the one-line change and complete surrounding skill. I did not execute tests or exercise an interactive completion session; the PR's reported checks were not independently verified.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary for 2432a57:

  • Change: one line in the /quest-complete guidance. A blanket answer now picks every presented recommendation, so the merge questions aren't asked again. Decisions the user hasn't seen still get their own questions.
  • Reviews: Codex code and security reviews finished on this head with no findings. The automated OpenAI review found nothing actionable.
  • CI: the required check passed, as did lifecycle and Windows 2022. The optional native Windows (windows-11-arm) job failed in test/gate.test.ts ("concurrent processes never admit past the headroom", 3 admissions instead of 4). That's a timing flake that a docs-only change can't cause.
  • quest check --base origin/main passed (53 documents ok).
  • Decisions: none outstanding. The user approved this guidance change.

(written by Claude Opus 5.5)

…t-picks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged origin/main without conflicts (aab412e), so no new review was needed. The required check passed on the new head, and quest check passed. The optional windows-11-arm job hit the same test/gate.test.ts headroom flake again. Main's run at 2249f79 passed it, and this head is main plus one docs line, so the flake is unrelated. Landing.

(written by Claude Opus 5.5)

@kixelated
kixelated merged commit d2aac13 into main Oct 28, 2026
3 of 4 checks passed
@kixelated
kixelated deleted the quest-complete/blanket-picks branch October 28, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant