Repository navigation
Report reviews and checks accurately in wait and status - #250
Conversation
Quest-Claim: 4f94f1757a47d1dc
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 6a68bcc
No actionable bugs found in the changed code. The direction is sound: an independent edit cursor and update-filtered pagination handle older status comments without conflating activity sources; required-pass naming stays separate from optional failures; and review-round counting reports history without assigning reviewer authority. The added complexity is justified by GitHub's creation ordering and second-resolution timestamps.
Verification: static inspection of the diff, surrounding wait/status logic, and regression tests covering resume deduplication, same-second edits, older pages/cursors, optional failures, and paged design markers. I did not execute tests or independently verify the PR's reported test results. State, head, and existing reviews were rechecked immediately before publication.
|
Merge summary: head (written by Claude Opus 5.5) |
# Conflicts: # assets/skills/merge.md # quest/m0/helpers/README.md # quest/m0/helpers/landing.md # quest/m0/helpers/wait-accuracy.md
|
Update: since my earlier summary,
Local checks: (written by Claude Opus 5.5) |
…-accuracy # Conflicts: # README.md # quest/m0/helpers/README.md # quest/m0/helpers/wait-accuracy.md # src/cli/status.ts # test/status.test.ts
|
Status:
Quest docs: Locally, (written by Claude Opus 5.5) |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Merge summary: head (written by Claude Opus 5.5) |
Bot status-comment edits now wake
quest wait, including edits on older comment pages. Optional CI failures print separately ascheck:failed; aggregatechecks:passedalways names a required check while retaining the head-idle timestamp. Resume cursors deduplicate edits and optional failures, including distinct edits in the same second, and migrate older cursors.quest statusnow reports paged review history as distinct reviewed commits since the latestDesign change:comment. CLI help, README, and the merge skill describe these facts. The completed wait-accuracy quest is removed.Validation:
just check,just test(543 CLI tests passed, 2 platform skips; 361 Worker tests passed), focused wait/status/skills regressions (99 passed), andquest check(59 documents).Choices: review-rounds reports historical facts with marker author and URL; it does not assign reviewer authority or change merge policy. Comment edits use update-filtered pagination from the first page because GitHub orders comments by creation.
(written by Codex (GPT-6))