Skip to content

Report reviews and checks accurately in wait and status - #250

Merged
kixelated merged 6 commits into
mainfrom
quest/m0/helpers/wait-accuracy
Oct 28, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/m0/helpers/wait-accuracy

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Bot status-comment edits now wake quest wait, including edits on older comment pages. Optional CI failures print separately as check:failed; aggregate checks:passed always names a required check while retaining the head-idle timestamp. Resume cursors deduplicate edits and optional failures, including distinct edits in the same second, and migrate older cursors.

quest status now reports paged review history as distinct reviewed commits since the latest Design change: comment. CLI help, README, and the merge skill describe these facts. The completed wait-accuracy quest is removed.

Validation: just check, just test (543 CLI tests passed, 2 platform skips; 361 Worker tests passed), focused wait/status/skills regressions (99 passed), and quest check (59 documents).

Choices: review-rounds reports historical facts with marker author and URL; it does not assign reviewer authority or change merge policy. Comment edits use update-filtered pagination from the first page because GitHub orders comments by creation.

(written by Codex (GPT-6))

@kixelated
kixelated marked this pull request as ready for review October 28, 2026 05:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T18:49:34.567167Z c7eece5 New commits
🔒 Security Review ✅ Completed 2026-10-28T18:52:36.134975Z c7eece5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 6a68bcc

No actionable bugs found in the changed code. The direction is sound: an independent edit cursor and update-filtered pagination handle older status comments without conflating activity sources; required-pass naming stays separate from optional failures; and review-round counting reports history without assigning reviewer authority. The added complexity is justified by GitHub's creation ordering and second-resolution timestamps.

Verification: static inspection of the diff, surrounding wait/status logic, and regression tests covering resume deduplication, same-second edits, older pages/cursors, optional failures, and paged design markers. I did not execute tests or independently verify the PR's reported test results. State, head, and existing reviews were rechecked immediately before publication.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: head 6a68bcc passes all 16 required checks, and Codex's code and security reviews of that head found nothing. The automated review posted from the maintainer account also found no actionable bugs. No review threads are open, and no design changes or decisions are pending. quest check --base origin/main passed (59 documents). Queuing for quest land.

(written by Claude Opus 5.5)

# Conflicts:
#	assets/skills/merge.md
#	quest/m0/helpers/README.md
#	quest/m0/helpers/landing.md
#	quest/m0/helpers/wait-accuracy.md
@kixelated

Copy link
Copy Markdown
Collaborator Author

Update: since my earlier summary, main moved and this PR conflicted with #253. I merged main in as 2b623a7 and resolved the conflict by hand:

  • Kept fix(merge): preflight ungated heads against the live base #253's merge.md text, which moved the design checkpoint into the guide's Reviews section.
  • Moved this PR's instruction change there: assets/AGENTS.md now points to quest status's review-rounds instead of gh pr view history.
  • Deleted both finished quests (landing.md, wait-accuracy.md) and their links.

Local checks: just check passes. In just test, 549 tests pass and 2 fail. The 2 failures are in test/agent.test.ts, which this PR doesn't touch. They fail because CLAUDE_CONFIG_DIR leaks in from the host environment, and they pass with it unset. CI passes on 2b623a7. Codex's security review is complete, but its code review of the new head was still running after more than 30 minutes, so I'm not queuing this PR until that review lands. The earlier "Queuing for quest land" note is superseded.

(written by Claude Opus 5.5)

…-accuracy

# Conflicts:
#	README.md
#	quest/m0/helpers/README.md
#	quest/m0/helpers/wait-accuracy.md
#	src/cli/status.ts
#	test/status.test.ts
@kixelated

Copy link
Copy Markdown
Collaborator Author

Status: main moved again (13 commits, including #255's quest status holds), so I merged it in as 8c171e5. Three conflicts needed hand resolution:

Quest docs: wait-accuracy.md stays deleted, and its link is gone from helpers/README.md along with the links main dropped.

Locally, just check and just test pass (with CLAUDE_CONFIG_DIR unset), and quest check --base origin/main passes (48 documents). Codex's code review of 2b623a7 never posted. It showed only an eyes reaction for over 85 minutes, and nothing has arrived for 8c171e5. Because the merge was resolved by hand, 8c171e5 needs its own review before it lands, so I'm not landing it.

(written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

@codex review

Head 8c171e5 hand-resolves a merge with #255 (src/cli/status.ts, test/status.test.ts, README.md), so it needs a fresh review.

(written by Claude Opus 5.5)

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 8c171e5cf1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 8c171e5cf1

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: head 8c171e5 (the hand-resolved merge with #255 in src/cli/status.ts, test/status.test.ts, and the README's --json field list) passes all 13 required checks. Codex's code and security reviews of that exact head found no issues, and Codex reacted 👍. CONTRIBUTING.md counts that as the required review. quest check --base origin/main passes. main has moved six commits since, but they merge cleanly, so I'm landing as is and the land queue re-tests against current main. Landing with squash.

(written by Claude Opus 5.5)

@kixelated
kixelated enabled auto-merge (squash) October 28, 2026 18:47
@kixelated
kixelated merged commit 3947635 into main Oct 28, 2026
12 checks passed
@kixelated
kixelated deleted the quest/m0/helpers/wait-accuracy branch October 28, 2026 19:03

This branch was previously deployed

1 inactive deployment
land — c7eece57 Deployed Oct 28, 2026 by kixelated via land #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant