Skip to content

Show pull request ownership in quest status - #255

Merged
kixelated merged 4 commits into
mainfrom
quest/m0/helpers/status-holds
Oct 28, 2026
Merged

kixelated merged 4 commits into
mainfrom
quest/m0/helpers/status-holds

Conversation

@kixelated

@kixelated kixelated commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

quest status now reports each quest:* hold's label, acquisition token/time, age, and verified GitHub event API URL. It uses the state commands' shared read-only reader, checks that the head stays consistent with the paged PR status, and leaves unknown acquisition facts explicit. A draft its starter owns reports its PR link and last activity, without treating activity as the ownership acquisition time.

Update the README's output contract and the complete workflow to consume these ownership facts without a separate label read. Status adds an ownership snapshot request and pages GitHub's event listing only when acquisition tokens need verified URLs; it never changes labels.

Validation: just check and just test passed (543 CLI tests, 2 skipped; 361 Worker tests), including latest-token ownership, paged event URL matching, missing acquisitions, mismatched event/label identities, draft hand-back/closed states, and a head changing before ownership is read. A read-only live run against the held merge-holds PR confirmed the acquisition token, time, age, and event URL.

Completes the status-holds quest.

(written by GPT-6)

@kixelated kixelated changed the title Show PR holds in quest status Show pull request ownership in quest status Oct 28, 2026
@kixelated
kixelated marked this pull request as ready for review October 28, 2026 05:40
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T16:38:40.416349Z 0324555 New commits
🔒 Security Review ✅ Completed 2026-10-28T16:40:53.958875Z 0324555 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 04a67c6

No actionable bugs found in the changed code. The direction is sound: reusing the ownership reader avoids a separate interpretation of hold labels, unknown acquisition facts remain explicit, and REST event URLs are matched by both token and label rather than fabricated from GraphQL IDs. The extra read-only requests are justified by those facts; the head-consistency guard and focused regression cases cover the main integration risks.

Verification: static inspection of the diff, ownership/status readers, shared GitHub pagination/error handling, and added tests. I did not run tests or reproduce live GitHub behavior. These remain non-atomic snapshots; the new head check does not freeze concurrent label or draft-state changes.

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: head 04a67c6 passed all 16 checks, and Codex's code and security reviews of that head found nothing. quest check --base origin/main passed (59 documents), and the PR deletes the finished status-holds quest along with its links. No changes or open decisions were needed. Landing as a squash merge.

(written by Claude Opus 5.5)

kixelated and others added 2 commits October 28, 2026 09:35
# Conflicts:
#	quest/m0/helpers/wait-accuracy.md
Main moved the hold helpers to src/core/hold.ts (#251), removing the local
latest() that status ownership read.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated
kixelated disabled auto-merge October 28, 2026 16:37
@kixelated

Copy link
Copy Markdown
Collaborator Author

Merged main into the branch (now 0324555), since GitHub reported a conflict:

  • quest/m0/helpers/wait-accuracy.md: each side deleted one of the two Related links (main removed landing.md, this PR removed status-holds.md). That left the section empty, so I dropped it.
  • A semantic conflict: Release ended merge holds through one shared policy #251 moved latest() to latestHold() in src/core/hold.ts, so readHoldStatus now calls latestHold(snapshot.events, label).

just check and just test pass. I disabled auto-merge until the new head gets a review.

(written by Claude Opus 5.5)

@kixelated

Copy link
Copy Markdown
Collaborator Author

Merge summary: head 0324555 merges main and fixes readHoldStatus for #251's move of latest() to latestHold(). Codex's code and security reviews of this head found nothing, and every required check passed. quest check --base origin/main passed (53 documents). Main has since gained #256, which touches different files and merges cleanly. Landing as a squash merge.

(written by Claude Opus 5.5)

@kixelated
kixelated merged commit 8862f30 into main Oct 28, 2026
11 checks passed
@kixelated
kixelated deleted the quest/m0/helpers/status-holds branch October 28, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant