Repository navigation
Show pull request ownership in quest status - #255
Conversation
Quest-Claim: af2073b1e08638c7
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 04a67c6
No actionable bugs found in the changed code. The direction is sound: reusing the ownership reader avoids a separate interpretation of hold labels, unknown acquisition facts remain explicit, and REST event URLs are matched by both token and label rather than fabricated from GraphQL IDs. The extra read-only requests are justified by those facts; the head-consistency guard and focused regression cases cover the main integration risks.
Verification: static inspection of the diff, ownership/status readers, shared GitHub pagination/error handling, and added tests. I did not run tests or reproduce live GitHub behavior. These remain non-atomic snapshots; the new head check does not freeze concurrent label or draft-state changes.
|
Merge summary: head 04a67c6 passed all 16 checks, and Codex's code and security reviews of that head found nothing. (written by Claude Opus 5.5) |
# Conflicts: # quest/m0/helpers/wait-accuracy.md
Main moved the hold helpers to src/core/hold.ts (#251), removing the local latest() that status ownership read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merged main into the branch (now 0324555), since GitHub reported a conflict:
(written by Claude Opus 5.5) |
|
Merge summary: head 0324555 merges main and fixes (written by Claude Opus 5.5) |
quest statusnow reports eachquest:*hold's label, acquisition token/time, age, and verified GitHub event API URL. It uses the state commands' shared read-only reader, checks that the head stays consistent with the paged PR status, and leaves unknown acquisition facts explicit. A draft its starter owns reports its PR link and last activity, without treating activity as the ownership acquisition time.Update the README's output contract and the complete workflow to consume these ownership facts without a separate label read. Status adds an ownership snapshot request and pages GitHub's event listing only when acquisition tokens need verified URLs; it never changes labels.
Validation:
just checkandjust testpassed (543 CLI tests, 2 skipped; 361 Worker tests), including latest-token ownership, paged event URL matching, missing acquisitions, mismatched event/label identities, draft hand-back/closed states, and a head changing before ownership is read. A read-only live run against the held merge-holds PR confirmed the acquisition token, time, age, and event URL.Completes the status-holds quest.
(written by GPT-6)