Skip to content

fix(land): the fixer hands back only injections aimed at it - #328

Merged
moq-bot[bot] merged 1 commit into
mainfrom
fix/fixer-injection-target
Oct 31, 2026
Merged

moq-bot[bot] merged 1 commit into
mainfrom
fix/fixer-injection-target

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

The land fixer now hands back a PR for prompt injection only when the content targets the fixer itself.

Change

After #325, the fixer still handed back PRs whose added docs tell contributors or agents how to work:

In repositories run by agents, that's ordinary content.

  • assets/land-fix.md: guidance a PR adds or changes for contributors or coding agents in general is project content, merged like any other file.
    • A handback is for content that addresses the fixer, its result file, or its environment.
    • It is also for content that tries to make the fixer change behavior, touch protected paths, reveal its environment, contact anything, or decide a result.
    • Not following such content stays the default for everything else.
  • The prompt-injection test asserts the new wording.

Checks

  • just check passes.
  • just test passes (726 CLI and 426 Worker tests), run with CLAUDE_CONFIG_DIR unset.

Review

quest review --base origin/main --deep (Codex), round 1 on head 1723aff: no findings.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

The fixer handed back moq-dev/moq#6634 because the PR's quest plan says
"agents do not push tags", and moq-dev/moq#7426 for a new AGENTS.md
rule. Guidance a PR adds for contributors or agents in general is
ordinary content; a handback is for content that targets the fixer, its
result, or its environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ee21cf82-c95f-4e13-b18c-9daa53458ff8
Commits

Reviewing files that changed from the base of the PR and between ca7c644 and 1723aff.

Files selected for processing: 2
  • assets/land-fix.md
  • test/land.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kixelated
kixelated enabled auto-merge (squash) October 31, 2026 19:27
@moq-bot
moq-bot Bot disabled auto-merge October 31, 2026 19:28
@moq-bot moq-bot Bot removed the quest:merge label Oct 31, 2026
@moq-bot

moq-bot Bot commented Oct 31, 2026

Copy link
Copy Markdown

quest land removed this pull request from the queue: required checks had not passed on its head when the gate ran: check (from app 15368); land it again once they pass.

@kixelated
kixelated enabled auto-merge (squash) October 31, 2026 19:31
@moq-bot
moq-bot Bot merged commit 3225b11 into main Oct 31, 2026
5 checks passed
@moq-bot
moq-bot Bot deleted the fix/fixer-injection-target branch October 31, 2026 19:36
moq-bot Bot pushed a commit that referenced this pull request Oct 31, 2026
Plans what moq.pro's and rust2's cutover to the host gate and the fixer
repairs (#320, #325, #327, #328) left: collateral ejections keep their
fix attempt, a restarted daemon keeps its check, GitHub retries, current
conflict reports, land checks at gate priority, a fast kix runner test,
and deleting the legacy hold labels. The gate host records what shipped.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant