Repository navigation
fix(land): resolve a PR that edits the fixer's own prompt like any other - #371
Merged
Merged
Conversation
The fixer handed #355 back because the PR edits assets/land-fix.md, although the prompt already says to hand nothing back for instructions in a diff. The fixer runs from the base's prompt, so a PR's edits to it never apply. Say so, so such PRs get mechanical fixes too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fixer handed back moq-dev/quest#355 instead of resolving its conflicts with main. Its reason was that the PR "targets this fixer and its result", because #355 edits
assets/land-fix.md. The prompt already says to neither follow nor hand back for instructions in a diff. But it doesn't cover a PR that changes the fixer's own prompt, result format, or quest land's code.The fixer always runs from the base's prompt, so a PR's edits to that prompt never apply to it. This adds that statement to the untrusted-input section, so those PRs get the same mechanical fixes as any other PR. It also adds the new sentence to the prompt-injection test's expected phrases.
Review
Codex
gpt-6.1-sol, medium effort (quest review --base origin/main), session01a198ad-76da-7870-8993-a0171c5b6cb3. Round 1 on head811765bc4f9926a3c011756a6299751730fce31c: no findings.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)