Repository navigation
feat(ts): translate a reference to a closure as a str pattern - #495
Merged
Merged
Conversation
Quest-Claim: 49b57178b2d16585
`s.contains(&f)` and `s.split(&mut f)` now translate for every `str` search, calling the borrowed closure as std does and leaving its drop to its owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kixelated
changed the title
kixelated
marked this pull request as ready for review
November 3, 2026 06:53
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 54 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A
strsearch given a reference to a closure as its pattern,s.contains(&f)ors.split(&mut f), failed translation as an unsupported call. std takes&Ffor anF: Fnand&mut Ffor anF: FnMut, as each implementsFnMut(char) -> bool.Approach
patternints/src/lower/library.rsnow accepts a closure or a function item behind any references.called_closures, which #471 extended, already reads a lent closure through its place and wraps it inrt.lentfor an iterator, and never drops it, so the owner drops it.ts/fixtures/task/src/drops/searched.rsgains two differential scenarios covering everystrsearch taking a pattern, values and iterators: one by&Fowning a guard (plus a cloned iterator and&char::is_whitespace), one by&mut Fowning a guard and counting its calls across every search, including through a&mut &mut F. A mutation wrapping a reference pattern inrt.oncefails the differential test, so the scenarios catch an early drop.Impact
ts/README.mdlists a reference to a predicate among the patterns that translate.Alternatives
Boxtoo, viacalled_through: left out, as an ownedBox<F>pattern is its own case with no test here.Follow-ups
To plan as quests (found while testing, out of scope):
fn(char) -> bool) orBox<dyn FnMut(char) -> bool>as astrpattern:patternmatches noty::FnPtrorBox.char::is_alphabetic(and othercharmethods without a mapping) as a function value: "unsupported call".Review
98138d58: no findings.0360e228adds only conflict-free merges oforigin/main;just cipassed on it.🤖 Generated with Claude Code