Repository navigation
refactor(vulnerability): remove legacy critical vulnerability issues and update messages - #564
Merged
Merged
Conversation
ybelMekk
force-pushed
the
fix/cleanup-vulnz-issues
branch
from
October 19, 2026 11:02
ee61acb to
64327c0
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The intended image-issue emission and severity contract needs reconciliation between the description and implementation.
1 open issue
What changed in this PR
Refactors workload vulnerability reporting to distinguish urgent external-ingress issues from known-exploited image warnings.
Changes:
- Stops emitting legacy critical-ingress issues.
- Suppresses image issues for urgent applications and makes remaining image issues warnings.
- Updates messages and test expectations.
| File | Description |
|---|---|
| internal/issue/checker/workload_v13s.go | Revises issue emission, deduplication, severity, and messages. |
| internal/issue/checker/workload_v13s_test.go | Updates unit assertions for issue selection and severity. |
| integration_tests/issues_for_team.lua | Updates GraphQL expectations for remaining issue types. |
Review effort: Balanced
ybelMekk
force-pushed
the
fix/cleanup-vulnz-issues
branch
from
October 20, 2026 06:27
0d72ae4 to
787a494
Compare
Contributor
Author
|
@thokra-nav, kan du se over denne PR-en og si om endringene ser riktige ut? |
christeredvartsen
approved these changes
Oct 20, 2026
christeredvartsen
left a comment
christeredvartsen
left a comment
Member
There was a problem hiding this comment.
Some of the deprecated fields have been used over the last two weeks according to our metrics, so we can hope it's only Console. 🙏
ybelMekk
force-pushed
the
fix/cleanup-vulnz-issues
branch
from
October 21, 2026 07:52
787a494 to
5901026
Compare
Contributor
Author
|
You can never say never 👍🏾 |
…and update messages
ybelMekk
force-pushed
the
fix/cleanup-vulnz-issues
branch
from
October 21, 2026 12:08
61cddbb to
4e48dd8
Compare
ybelMekk
enabled auto-merge (squash)
October 21, 2026 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vis ett sårbarhetsissue per workload:
EXTERNAL_INGRESS_URGENT_VULNERABILITY(CRITICAL) ved kjente utnyttede sårbarheter og bekreftet ekstern ingress. Ellers visesVULNERABLE_IMAGE(WARNING) når slike sårbarheter finnes. Flere oppsummeringer fra v13s gir ikke flere sårbarhetsissues for samme workload. Andre issue-typer, som manglende SBOM, påvirkes ikke.Fjerner den utgåtte GraphQL-typen
ExternalIngressCriticalVulnerabilityIssueog enum-verdienEXTERNAL_INGRESS_CRITICAL_VULNERABILITY, sammen med modell og resolvere. En migrasjon sletter lagrede issues av den gamle typen før API-et leser dem.Avhengighet: nais/console-frontend#666 må være merget og deployet før denne PR-en merges. Eldre åpne faner og andre klienter som fortsatt spør etter den fjernede typen, kan feile etter API-deploy.