refactor(vulnerability): remove legacy critical vulnerability issues and update messages

integration_tests/issues_for_team.lua

@@ -2,6 +2,7 @@ Helper.readK8sResources("k8s_resources/issues")
 local user = User.new("name", "auth@user.com", "sdf")
 Team.new("myteam", "purpose", "#slack_channel")
 Team.new("sortteam", "purpose", "#slack_channel")
+Team.new("devteam", "purpose", "#slack_channel")
 local checker = IssueChecker.new()
 checker:runChecks()
 
@@ -552,91 +553,84 @@ Test.gql("VulnerableImageIssue", function(t)
 		data = {
 			team = {
 				issues = {
-					nodes = {
-						{
-							__typename = "VulnerableImageIssue",
-							message = "Image 'vulnerable-image' has 2 known-exploited vulnerabilities",
-							severity = "CRITICAL",
-							critical = 5,
-							riskScore = 250,
-							workload = {
-								name = "vulnerable",
-							},
-						},
-					},
+					nodes = {},
 				},
 			},
 		},
 	}
 end)
 
-Test.gql("ExternalIngressUrgentVulnerabilityIssue", function(t)
+Test.gql("Known exploited workload without external ingress has only image issue", function(t)
 	t.addHeader("x-user-email", user:email())
 
 	t.query [[
 		query {
-			team(slug: "myteam") {
-				issues(
-					filter: {
-						issueType: EXTERNAL_INGRESS_URGENT_VULNERABILITY
-					},
-				) {
+			team(slug: "devteam") {
+				imageIssues: issues(filter: {issueType: VULNERABLE_IMAGE}) {
 					nodes {
 						__typename
 						severity
 						message
-						... on ExternalIngressUrgentVulnerabilityIssue {
-							priorityUrgent
-							ingresses
+						... on VulnerableImageIssue {
+							critical
+							riskScore
 							workload {
 								name
 							}
 						}
 					}
 				}
+				urgentIssues: issues(filter: {issueType: EXTERNAL_INGRESS_URGENT_VULNERABILITY}) {
+					nodes {
+						__typename
+					}
+				}
 			}
 		}
 	]]
 
 	t.check {
 		data = {
 			team = {
-				issues = {
+				imageIssues = {
 					nodes = {
 						{
-							__typename = "ExternalIngressUrgentVulnerabilityIssue",
-							message = "Workload 'vulnerable' (exposed via external ingress) has 2 urgent vulnerabilities",
-							severity = "CRITICAL",
-							priorityUrgent = 2,
-							ingresses = { "https://vulnerable.example.com" },
+							__typename = "VulnerableImageIssue",
+							severity = "WARNING",
+							message = "Image 'vulnerable-image' has 2 known-exploited vulnerabilities",
+							critical = 5,
+							riskScore = 250,
 							workload = {
 								name = "vulnerable",
 							},
 						},
 					},
 				},
+				urgentIssues = {
+					nodes = {},
+				},
 			},
 		},
 	}
 end)
 
-Test.gql("ExternalIngressCriticalVulnerabilityIssue remains queryable", function(t)
+Test.gql("ExternalIngressUrgentVulnerabilityIssue", function(t)
 	t.addHeader("x-user-email", user:email())
 
 	t.query [[
 		query {
 			team(slug: "myteam") {
 				issues(
 					filter: {
-						issueType: EXTERNAL_INGRESS_CRITICAL_VULNERABILITY
+						issueType: EXTERNAL_INGRESS_URGENT_VULNERABILITY
 					},
 				) {
 					nodes {
 						__typename
 						severity
 						message
-						... on ExternalIngressCriticalVulnerabilityIssue {
-							cvssScore
+						... on ExternalIngressUrgentVulnerabilityIssue {
+							priorityUrgent
 							ingresses
 							workload {
 								name
@@ -654,10 +648,10 @@ Test.gql("ExternalIngressCriticalVulnerabilityIssue remains queryable", function
 				issues = {
 					nodes = {
 						{
-							__typename = "ExternalIngressCriticalVulnerabilityIssue",
-							message = "Workload 'vulnerable' (exposed via external ingress) has 2 urgent vulnerabilities",
+							__typename = "ExternalIngressUrgentVulnerabilityIssue",
+							message = "Urgent: Workload 'vulnerable' is exposed via external ingress and has 2 known-exploited vulnerabilities",
 							severity = "CRITICAL",
-							cvssScore = 9.0,
+							priorityUrgent = 2,
 							ingresses = { "https://vulnerable.example.com" },
 							workload = {
 								name = "vulnerable",

integration_tests/k8s_resources/issues/dev-gcp/devteam/app-vulnerable.yaml

@@ -0,0 +1,6 @@
+apiVersion: nais.io/v1alpha1
+kind: Application
+metadata:
+  name: vulnerable
+spec:
+  image: europe-north1-docker.pkg.dev/nais/navikt/app-name:latest

internal/database/migrations/0078_remove_legacy_critical_vulnerability_issues.sql

@@ -0,0 +1,5 @@
+-- +goose Up
+DELETE FROM issues
+WHERE
+	issue_type = 'EXTERNAL_INGRESS_CRITICAL_VULNERABILITY'
+;