Repository navigation
Raise platform requirements for 4.0 - #125
Open
RandyCupic wants to merge 6 commits into
Open
RandyCupic wants to merge 6 commits into
RandyCupic wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the 4.0 platform requirements on top of the multi-upload branch (#124).
symfony/proxy-manager-bridge. Nothing used it, and it has no Symfony 7 release.ezpublish-legacy-dircomposer extra.The lower bound is PHP 8.3 + Symfony 5.4 because Akeneo 2026 pins
php 8.3.*and Symfony 5.4. The lowest-deps job installs the same set Akeneo uses: ORM 2.20.0, DBAL 2.13, doctrine-bundle 2.7, Symfony 5.4.0. The plan is to raise the floor to PHP 8.4 + Symfony 7.4 in a later 4.x minor, once Akeneo supports it.Akeneo note: Cloudinary SDK 3 requires
psr/log ^2|^3, but Akeneo pinselasticsearch/elasticsearch 7.11.0, which requirespsr/log ~1.0. To install 4.0, the Akeneo project needs"elasticsearch/elasticsearch": "7.17.3 as 7.11.0"in its root composer.json. This was verified with a composer dry-run against the project lock file.Code changes needed for the new platform:
mixedparameter and return types, as required by Symfony 7+.rateLimitResetAtisint|falsein SDK 3).EntityRepository), Cloudinary SDK 3 (ApiResponsereturn values) and Symfony 8 (Application::addCommand()).CI:
masterand on everyX.Ybranch.^8.0constraint still covers 8.1.Tested locally on PHP 8.4. Tests (641) pass on Symfony 5.4 (normal and lowest), 7.4 and 8.1. PHPStan and CS are clean.
Known gap: the
array/objectcolumn types in the Doctrine mappings no longer exist in DBAL 4. An application on DBAL 4 will fail when it loads the mapping, even though the tests pass. This is handled separately by converting those columns to JSON.