Repository navigation
nix: drop removed darwin.apple_sdk frameworks from dev shell - #77
Merged
Merged
Conversation
wesnel
force-pushed
the
nix-drop-apple-sdk
branch
from
November 11, 2026 21:46
a70c27d to
fb1de98
Compare
nixpkgs removed darwin.apple_sdk, so on macOS evaluating the dev shell with the pinned nixpkgs fails with "darwin.apple_sdk_11_0 has been removed as it was a legacy compatibility stub". The Darwin stdenv now ships the default macOS SDK with all its frameworks, so the shell no longer needs to list Security itself. libiconv stays. flake-utils has no nixpkgs input, so its follows override only produced a warning; drop it too. flake.lock is unchanged.
wesnel
force-pushed
the
nix-drop-apple-sdk
branch
from
November 11, 2026 22:00
fb1de98 to
642a2ba
Compare
wesnel
marked this pull request as ready for review
November 12, 2026 00:09
wesnel
requested review from
andrew-harris-at-ngrok,
grant-higgins-0,
joshbottelberghe,
kevin-ngrok and
sajethm
November 12, 2026 00:09
joshbottelberghe
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS,
direnv allow(ornix develop) fails to evaluate the dev shell with the pinned nixpkgs:nixpkgs has removed
darwin.apple_sdk. The Darwin stdenv now ships the default macOS SDK with all its frameworks, so the dev shell no longer listsSecurityitself (migration notes).libiconvstays. This is the same fix as ngrok/ngrok-rust#208.This also drops
inputs.nixpkgs.followsfromflake-utils: flake-utils has nonixpkgsinput, so the override only produced a warning.flake.lockis unchanged.Stacked on #78, which fixes the CI job that fails on
main.Validation
On aarch64-darwin, with the existing
flake.lock:nix eval .#devShell.aarch64-darwin.drvPathfails with the error above before this change and succeeds after it, without the flake-utils warning.nix developbuilds the shell;cargo,rustc,cargo udeps,java(17) andmvnrun in it.mvn -pl ngrok-java-native -am -DskipTests packagesucceeds in the shell, and the builtlibngrok_java.dyliblinksSecurity.frameworkandCoreFoundation.frameworkfrom/System/Library/Frameworks, andlibiconvfrom Nix.nix eval .#devShell.x86_64-linux.drvPathgives the same derivation before and after.Weak spots, assumptions and decisions
apple-sdk_*package inbuildInputs, which would be needed if a future nixpkgs default SDK dropped something the native crate links.Reverting
A two-way door: it touches only the dev shell definition. Reverting it breaks the dev shell on macOS again with the current
flake.lock; nothing else is left behind.