Repository navigation
ci: download Maven from the Apache archive - #78
Merged
Merged
Conversation
dlcdn.apache.org serves only current releases and now answers 404 for Maven 3.9.12. curl -sL saved that error page as maven.tar.gz, so the step failed at the checksum instead of at the download. archive.apache.org keeps every release, and its 3.9.12 tarball matches the pinned SHA-512. curl now takes -f and -S, so an HTTP error fails the download and is printed.
wesnel
force-pushed
the
ci-maven-download
branch
from
November 11, 2026 21:59
f7773c3 to
c926c6f
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the Maven download updates in the CI and release workflows.
No open issues 🎉
What changed in this PR
Fixes Maven downloads in CI and release workflows by using the Apache archive, avoiding failures when the pinned release is removed from the download CDN.
Changes:
- Switches both workflows to
archive.apache.org, preserving Maven 3.9.12 and its pinned SHA-512 checksum. - Adds curl’s
-fand-Sflags so HTTP errors fail the download immediately and display an error message.
| File | Description |
|---|---|
.github/workflows/release-perform.yml |
Updates the container Maven download URL and error handling for releases. |
.github/workflows/ci.yml |
Applies the same download fix to the CI build. |
Review effort: Balanced
wesnel
marked this pull request as ready for review
November 12, 2026 00:09
wesnel
requested review from
andrew-harris-at-ngrok,
grant-higgins-0,
joshbottelberghe,
kevin-ngrok and
sajethm
November 12, 2026 00:09
joshbottelberghe
approved these changes
Nov 13, 2026
joshbottelberghe
left a comment
There was a problem hiding this comment.
Looks good. Checked the archive URL serves 3.9.12 and its .sha512 matches the pin; dlcdn is 404. CI green at c926c6f.
Optional: Maven Central has the same tarball and hash (repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.12/), CDN-backed, if the archive's rate limit ever bites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Build Ngrok Java (glibc 2.28)CI job fails onmainbefore it builds anything:dlcdn.apache.orgnow answers 404 for Maven 3.9.12.curl -sLsaved that error page asmaven.tar.gz, so the step failed at the checksum rather than at the download. Bothci.ymlandrelease-perform.ymlnow download Maven fromarchive.apache.org, which keeps every release, with the same pinned SHA-512.curlalso takes-fand-S, so an HTTP error now fails the download step and prints why.#77 is stacked on this.
Validation
https://dlcdn.apache.org/maven/maven-3/3.9.12/binaries/apache-maven-3.9.12-bin.tar.gzreturns HTTP 404.archive.apache.orgtarball's SHA-512 equals both Apache's published.sha512for it and the value pinned in the workflows.Weak spots, assumptions and decisions
release-perform.ymlgets the same change but only runs on a release, so this pull request's CI does not exercise it.archive.apache.orgstays reachable from GitHub runners and keeps old releases; if it does not, the download step now fails with the HTTP error. The alternative not taken is bumping Maven to a version dlcdn serves today, which would break again on the next Maven release.-fis a choice beyond the URL fix; without it, a future 404 again surfaces as a checksum mismatch.Reverting
A two-way door: it changes only how CI downloads Maven. Reverting it brings back the 404 and the failing job; nothing else is left behind.