Skip to content

deps: bump ngrok to 0.19.0 - #215

Merged
wesnel merged 2 commits into
wgn/flaky-tcp-endpoint-testsfrom
wgn/agent-1371-ngrok-0.19.0
Nov 13, 2026
Merged

wesnel merged 2 commits into
wgn/flaky-tcp-endpoint-testsfrom
wgn/agent-1371-ngrok-0.19.0

Conversation

@wesnel

@wesnel wesnel commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Part of AGENT-1371.

Moves the ngrok crate from 0.18.0 to 0.19.0. The fix for AGENT-1371, a cap on the wait between session reconnect attempts, ships in ngrok 0.19.1, which #216, stacked on this, moves to. Taking 0.19.0 here keeps that bump small.

  • Cargo.lock changes only through cargo update -p ngrok -p muxado: ngrok 0.19.0, muxado 0.5.4, tokio-retry 0.3.2 (which ngrok 0.19.0 requires), and the rand 0.10 packages tokio-retry 0.3.2 depends on.
  • The JavaScript API does not change. src/ builds against 0.19.0 as it is, and the generated index.js and index.d.ts come out the same.
  • Rust moves forward. ngrok 0.19.0 and muxado 0.5.4 use let chains, which need Rust 1.88. The flake's fenix pin gave 1.87.0-nightly, and the napi-rs Docker images used in CI ship Cargo 1.82. Only the fenix-flake input moves, to a nightly with rustc 1.102, and the Docker build step updates the image's stable toolchain and adds the job's target before building, so the musl jobs no longer add their target themselves. The newer clippy rejected two things in src/, both fixed in that commit: an allow for a lint that no longer exists, and a map loop that used only the values.

Validation

  • cargo build --release, cargo clippy --all-targets --all-features --workspace -- -D warnings and cargo fmt --all -- --check pass under nix develop, on the toolchain commit alone and on the bump.
  • yarn build on the bump leaves index.js and index.d.ts unchanged.
  • yarn test could not pass where this was built, because there was no NGROK_AUTHTOKEN and no outbound network. The tests failed the same way before and after the bump, so CI is the test of record for behaviour.

Weak spots, assumptions and decisions

  • The fenix nightly jumps from 2025-03-10 to 2026-11-10. The udeps, fmt and clippy CI jobs use it, so a lint or tool change beyond the two fixed here would show up in CI first.
  • The CI jobs that build inside the napi-rs nodejs-rust:lts-* images used the image's own stable Rust, Cargo 1.82, which can't parse edition-2024 manifests. Their build step now runs rustup update stable and adds the job's target first, so each run downloads the current stable toolchain. That makes the jobs slower, and they now depend on whatever stable is at the time.
  • The two musl builds (x86_64-unknown-linux-musl, aarch64-unknown-linux-musl) run only on main, so this pull request's CI never runs the changed Docker step for them. Their first run is the push to main after this merges; the Publish workflow runs the same CI before it publishes, so a failure there stops the release rather than shipping without those bindings.
  • Decision: move the toolchain rather than keep muxado at 0.5.0. ngrok 0.19.0 accepts any muxado 0.5, but ngrok-rust tests 0.19.0 with 0.5.4.
  • verify_upstream_tls(false) now uses the process's default rustls crypto provider. Only aws-lc-rs is enabled in this build, so it stays aws-lc-rs. This was read from the source, not tested.

Reverting

Two-way door. Reverting puts back ngrok 0.18.0 and the older toolchain, with nothing stored or published. If this is reverted after the reconnect options merge, those have to go too, because they need 0.19.x.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the SDK dependency and toolchain updates.

No open issues 🎉

What changed in this PR

Updates the native SDK dependency to ngrok 0.19.0, preparing for a later 0.19.x release with the reconnect-wait cap for AGENT-1371. The JavaScript API remains unchanged.

Changes:

  • Bumps ngrok and updates muxado, tokio-retry, and related lockfile dependencies.
  • Advances the Nix Rust toolchain and updates stable Rust before Docker builds.
  • Applies two compatibility cleanups for the newer Clippy.
File Description
src/​session.rs Removes an allowance for a removed lint.
src/​listener.rs Iterates directly over listener storage values.
flake.lock Advances Fenix and its rust-analyzer input.
Cargo.toml Bumps ngrok to 0.19.0.
Cargo.lock Locks updated ngrok and transitive dependencies.
.github/​workflows/​build.yml Updates Docker’s stable Rust toolchain and installs the build target.

Review effort: Balanced

@wesnel
wesnel removed this pull request from stack #217 November 11, 2026 23:51
@wesnel
wesnel changed the base branch from main to wgn/flaky-tcp-endpoint-tests November 11, 2026 23:57
@wesnel
wesnel force-pushed the wgn/agent-1371-ngrok-0.19.0 branch from b043856 to 4efda3c Compare November 11, 2026 23:57
@wesnel
wesnel added this pull request to stack #219 November 11, 2026 23:58
@wesnel
wesnel marked this pull request as ready for review November 12, 2026 00:02
@sajethm sajethm self-assigned this Nov 12, 2026
Comment thread .github/workflows/build.yml Resolved
ngrok-rust 0.19.0 locks muxado 0.5.4, which uses let chains; they are
stable from Rust 1.88. Its dependencies also include crates on edition
2024, which Cargo before 1.85 cannot parse.

The dev shell's fenix pin gave rustc 1.87.0-nightly (2025-03-09), which
rejects the let chains with E0658. The udeps, fmt and clippy CI jobs load
the same shell through direnv. Only the fenix-flake input moves (and its
rust-analyzer-src); nixpkgs stays. The new nightly is rustc
1.102.0-nightly (2026-11-10).

The CI jobs that build inside the napi-rs nodejs-rust:lts-* images use the
stable toolchain baked into the image when it was built, Cargo 1.82.0,
which fails on rand 0.10.3 with "feature edition2024 is required". The
Docker build step now updates that toolchain with rustup, which each image
has, and adds the job's target to it, as the other build jobs do.

The new nightly's clippy rejects two things in src/, fixed here:
- the dependency_on_unit_never_type_fallback lint no longer exists, so
  allowing it is an error; the code it covered was fixed by naming the
  call_async return type.
- search_listeners iterated a map's pairs to use only its values.
The reconnect fix of AGENT-1371 ships in a later 0.19.x release of
ngrok-rust; moving to 0.19.0 first keeps that later bump small.

Cargo.lock comes from `cargo update -p ngrok -p muxado` alone:
- ngrok 0.18.0 -> 0.19.0: the requested version.
- muxado 0.5.0 -> 0.5.4: ngrok's multiplexer, released with 0.19.0.
- tokio-retry 0.3.0 -> 0.3.2: ngrok 0.19.0 requires 0.3.2, the first
  version with RetryIf::start.
- rand 0.10.3, rand_core 0.10.1, chacha20 0.10.2, getrandom 0.4.3,
  cpufeatures 0.3.1 and r-efi 6.0.0 are added: tokio-retry 0.3.2 depends
  on rand 0.10, and these are its dependencies.

src/ needs no change: it builds against 0.19.0 unchanged.

muxado 0.5.4 uses let chains, stable since Rust 1.88, so the crate needs
Rust 1.88 or later, not the 1.85 that edition 2024 alone needs.
@wesnel
wesnel force-pushed the wgn/agent-1371-ngrok-0.19.0 branch from 4efda3c to 14206eb Compare November 13, 2026 00:46
@wesnel wesnel mentioned this pull request Nov 13, 2026
@wesnel
wesnel merged commit ee42133 into main Nov 13, 2026
45 of 46 checks passed
@wesnel
wesnel deleted the wgn/agent-1371-ngrok-0.19.0 branch November 13, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants