Skip to content

fix: require current-rig review before vector eye approval - #16

Draft
nkcbuilds wants to merge 1 commit into
feat/vector-eyelid-rigfrom
fix/vector-eyelid-current-review
Draft

nkcbuilds wants to merge 1 commit into
feat/vector-eyelid-rigfrom
fix/vector-eyelid-current-review

Conversation

@nkcbuilds

Copy link
Copy Markdown
Owner

Purpose

Fix an approval-integrity hole in draft PR #15: after vectorizing an imported character, the four pre-existing review/*.png sheets can still be from the old raster-lash model. Prior character approve --reviewed checked the current rig's provenance but only that review PNGs existed, so the altered eyelid geometry could be approved with stale visual evidence.

Draft stacked PR, base feat/vector-eyelid-rig (#15). It depends on the existing draft stack; do not merge this alone into main.

Change

  • After character eyes vectorize renders the actual 36-frame/30 FPS timed blink, publish a unique local review package containing blink-eyes.png, blink-full.png, and blink-timed-30fps.mp4 under review/vector-eyes-<uuid>/. Original user artwork, model, and previous packages are never overwritten.
  • Atomically write review/vector-eyelids-proof.json binding the current model SHA-256 from avatar-build.json and each review file's SHA-256. Verify before/after capture. This is a byte-continuity claim, not an aesthetic quality pass or a cryptographic human signature.
  • The explicit approval workflow now requires a matching current-model package for vector eyelid geometry, even when a vectorized rig is renamed. Partial vector topology, stale/missing/tampered contact sheets, stale model hashes, mismatched filenames and out-of-package paths fail closed. For nonvector imported rigs, prior approval behavior is unchanged.
  • New recovery command: character eyes review <project-dir> regenerates evidence for an existing verified vector rig without modifying or approving the character. It preserves prior approval state accurately; no automatic approval.
  • Updated CLI help, review docs, roadmap, README and agent skill.

Reproduction / real evidence

On a disposable unapproved copy of the locally MIT-licensed Hana import:

  1. Ran character eyes vectorize .cache/avatar-onboarding/vector-review-proof-20261108 --experimental. The command produced a separate derived model and current SHA-256 proof with three genuine Rev2D/FFmpeg output files; character inspect reported assetIntegrity: verified, approved: false.
  2. Ran character eyes review ... again. It wrote a second uniquely named evidence package, rebound the fixed proof file and kept the character approved:false. A direct verification call confirmed three exact matching current-model artifacts.
  3. The package's actual H.264 MP4 passed FFprobe: 512×640, 30 FPS, 36 frames, 1.200 seconds. Opened and visually inspected the real 6×6 eye contact sheet; the cleaner continuous vector lash closure remains, with simplified line style and no automatic visual approval.
  4. Existing earlier feat: continuous vector eyelid rig for imported avatars #15 full-scene 90-frame smoke render remains valid. No user art or private QA media was committed.

Regression

npm run verify passed 231 tests / 40 files, including six new tests for missing proof, valid model-bound proof without auto approval, modified sheet bytes, changed rig hash after recapture, malformed path/missing video, and renamed vector geometry bypass. Typecheck/build and git diff --check passed.

Remaining quality gate

This prevents a stale-review approval mistake, but does not prove that a human inspected the frames or that all eye/head/gaze/mouth combinations look good. Only one distinct MIT-licensed humanoid sample has been exercised; other local upstream examples are not independent compatible humanoid art. Additional rights-cleared styles and expression/gaze stress reviews remain open. Keep PR #16 and the stack in draft until review.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant