Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix an approval-integrity hole in draft PR #15: after vectorizing an imported character, the four pre-existing
review/*.pngsheets can still be from the old raster-lash model. Priorcharacter approve --reviewedchecked the current rig's provenance but only that review PNGs existed, so the altered eyelid geometry could be approved with stale visual evidence.Draft stacked PR, base
feat/vector-eyelid-rig(#15). It depends on the existing draft stack; do not merge this alone into main.Change
character eyes vectorizerenders the actual 36-frame/30 FPS timed blink, publish a unique local review package containingblink-eyes.png,blink-full.png, andblink-timed-30fps.mp4underreview/vector-eyes-<uuid>/. Original user artwork, model, and previous packages are never overwritten.review/vector-eyelids-proof.jsonbinding the current model SHA-256 fromavatar-build.jsonand each review file's SHA-256. Verify before/after capture. This is a byte-continuity claim, not an aesthetic quality pass or a cryptographic human signature.character eyes review <project-dir>regenerates evidence for an existing verified vector rig without modifying or approving the character. It preserves prior approval state accurately; no automatic approval.Reproduction / real evidence
On a disposable unapproved copy of the locally MIT-licensed Hana import:
character eyes vectorize .cache/avatar-onboarding/vector-review-proof-20261108 --experimental. The command produced a separate derived model and current SHA-256 proof with three genuine Rev2D/FFmpeg output files;character inspectreportedassetIntegrity: verified,approved: false.character eyes review ...again. It wrote a second uniquely named evidence package, rebound the fixed proof file and kept the characterapproved:false. A direct verification call confirmed three exact matching current-model artifacts.Regression
npm run verifypassed 231 tests / 40 files, including six new tests for missing proof, valid model-bound proof without auto approval, modified sheet bytes, changed rig hash after recapture, malformed path/missing video, and renamed vector geometry bypass. Typecheck/build andgit diff --checkpassed.Remaining quality gate
This prevents a stale-review approval mistake, but does not prove that a human inspected the frames or that all eye/head/gaze/mouth combinations look good. Only one distinct MIT-licensed humanoid sample has been exercised; other local upstream examples are not independent compatible humanoid art. Additional rights-cleared styles and expression/gaze stress reviews remain open. Keep PR #16 and the stack in draft until review.