Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PuppetControl now wraps the pinned Rev2D drawn eye/mouth-variant workflow with explicit local-art selection, project confinement and fail-closed approval handling:
character variants requestcreates edit masks/prompts;statusinspects the resulting variant states;import <ids...> --reviewed-artchecks full-resolution PNG artwork and calls the upstream acceptance validator.--experimental-short-fade, requiring both accepted drawneyes_closedandeyes_halffor both sides. It narrows Rev2D's sprite-over-sprite and sprite-over-mesh opacity fade windows to EyeOpen 0.18–0.20 and 0.68–0.70. Unsupported/unknown eye topologies are refused. The derived model is validated via Rev2D before atomic replacement, its review sheets are refreshed, and its hashes are updated. The default is unchanged and a subsequent import without the switch restores upstream curves.Verified real-image evidence
Using only the pinned Rev2D Hana MIT source, on a disposable imported 512×640 rig:
unchangedand no approval.--experimental-short-fadeon a separate disposable project. Both drawings accepted, Rev2D model validated, review sheets regenerated, asset fingerprints verified, and character remained approved:false. Scene validation still blocks withDEFAULT_POSE_NOT_APPROVED.outputs/qa/eyelid-switch-20261107/; no generated art was committed.Validation
npm run verify: 132 tests passed across 22 test files, TypeScript typecheck/build green.git diff --checkclean.Caveats