Skip to content

feat: guarded local drawn eye and mouth variants - #7

Draft
nkcbuilds wants to merge 2 commits into
mainfrom
feat/rev2d-drawn-variants
Draft

nkcbuilds wants to merge 2 commits into
mainfrom
feat/rev2d-drawn-variants

Conversation

@nkcbuilds

@nkcbuilds nkcbuilds commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

What changed

PuppetControl now wraps the pinned Rev2D drawn eye/mouth-variant workflow with explicit local-art selection, project confinement and fail-closed approval handling:

  • character variants request creates edit masks/prompts; status inspects the resulting variant states; import <ids...> --reviewed-art checks full-resolution PNG artwork and calls the upstream acceptance validator.
  • Imports revoke previous pose approval before any model/texture mutation, regenerate review sheets, and refresh source/spec/model/texture fingerprints only on full success.
  • Upstream rejection codes, reasons and hints are preserved in actionable CLI errors; rejected/partial imports never auto-approve.
  • New opt-in experimental option: --experimental-short-fade, requiring both accepted drawn eyes_closed and eyes_half for both sides. It narrows Rev2D's sprite-over-sprite and sprite-over-mesh opacity fade windows to EyeOpen 0.18–0.20 and 0.68–0.70. Unsupported/unknown eye topologies are refused. The derived model is validated via Rev2D before atomic replacement, its review sheets are refreshed, and its hashes are updated. The default is unchanged and a subsequent import without the switch restores upstream curves.

Verified real-image evidence

Using only the pinned Rev2D Hana MIT source, on a disposable imported 512×640 rig:

  1. Requested real masks for eyes_closed, eyes_half, mouth_a; inspected actual masks and original frames.
  2. A deliberately unchanged eyes_closed drawing was rejected with code unchanged and no approval.
  3. Local-only test-quality closed/half drawings were accepted; both had outsideDiff=0 and nearDiff=0.
  4. Compared 13 actual 30fps blink frames: native crossfade shows double lash/iris outlines at EyeOpen 0.667 and 0.167; instant and short-fade variants show crisp single outlines at those samples. This trades ghosting for faster/poppier changes—not a universally smooth or production-ready fix.
  5. Ran the new guarded CLI import with --experimental-short-fade on a separate disposable project. Both drawings accepted, Rev2D model validated, review sheets regenerated, asset fingerprints verified, and character remained approved:false. Scene validation still blocks with DEFAULT_POSE_NOT_APPROVED.
  6. The rendered guarded-import PNG at EyeOpen 0.667 has the same SHA-256 as the separate shortened-fade experiment; different from native crossfade. The original source artwork and pinned engine were not modified. Local side-by-side 1024×640 H.264 comparison (13 frames at 30fps), intermediate PNGs, and review sheets remain under ignored outputs/qa/eyelid-switch-20261107/; no generated art was committed.

Validation

  • npm run verify: 132 tests passed across 22 test files, TypeScript typecheck/build green.
  • Pure transformation tests cover opacity curve bounds, unchanged unrelated channels, warp-parameter preservation, unsupported/missing sprite topology and invalid inputs.
  • git diff --check clean.

Caveats

  • Experimental short fades are optional and still blend for a very short interval; they may pop at normal frame rates. No arbitrary-avatar aesthetic claim.
  • The demonstration artwork is visibly too flat and remains unapproved. Long-term quality requires better matching intermediate drawings and more diverse visual benchmarks.
  • This PR and draft feat: bounded PNG animation quality probes #8 (pixel/temporal QA) both touch CLI/docs. Reconcile those overlaps during review; neither PR should be automatically merged.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant