Skip to content

feat: integrate character review and cue integrity gates - #10

Draft
nkcbuilds wants to merge 5 commits into
feat/first-video-mvpfrom
feat/character-review-gates
Draft

nkcbuilds wants to merge 5 commits into
feat/first-video-mvpfrom
feat/character-review-gates

Conversation

@nkcbuilds

Copy link
Copy Markdown
Owner

Goal

Make PuppetControl's existing reviewed-character first-video workflow more usable for actual new illustrations by integrating the two earlier draft quality branches (#7 and #8), rendering an actionable blink-review sheet, and ensuring optional voice/Rhubarb cue integrity. This branch is stacked on draft PR #9 (feat/first-video-mvp) and must not be merged independently into main.

Changes

  • Carefully cherry-picked and reconciled feat: guarded local drawn eye and mouth variants #7's guarded Rev2D drawn eye/mouth variants and optional experimental short-fade policy without removing feat: first reviewed-character video workflow #9's approval/scene commands.
  • Carefully cherry-picked and reconciled feat: bounded PNG animation quality probes #8's bounded PNG QA and time-ordered motion triage. Pixel difference is diagnostic, not aesthetic approval.
  • New character qa blink <imported-project>: validate provenance, render 13 real Rev2D eye states at transition boundaries, mirror to 25-frame ordered review montage, generate enlarged eye/full contact sheets and motion-stall JSON. Source/rig/approval unchanged.
  • Optional exact-byte voice/cue sidecar: audio bind, audio verify, scene new --binding. Bound scenes independently verify WAV and Rhubarb cue SHA-256 before validation and rendering and fail if tampered/moved. Legacy unbound scenes still work.
  • New docs/CHARACTER_REVIEW.md outlines correction workflow and explicit visual approval; documentation/skills refreshed.

Real evidence

  • Locally verified imported experimental Hana at .cache/avatar-onboarding/short-fade-import-20261107 has correct source/rig fingerprints, approved:false. Command character qa blink successfully produced 25 frames and local contact sheets under ignored outputs/qa/blink-review/85cb4479-ad75-40a2-8940-377de4bba860. Inspected the actual montage: still has skin-color patches, ghost lashes and unnatural half-eye states. 10 sampled motion-stall candidates; these are triage, not proof of defects.
  • Actual local test voice WAV + Rhubarb cues bound via new CLI, scene new with --binding and scene validate passed. Rendered 3s H.264/AAC video at 512x640, 15fps, 45 frames. FFprobe checker PASS; one video + one audio stream. All voice/model/test art stays ignored/local.
  • npm run verify: 188 tests across 32 files passed, TypeScript typecheck/build green.
  • git diff --check clean, working tree clean.

Explicit blockers, do not mark production-ready

@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@nkcbuilds

Copy link
Copy Markdown
Owner Author

Follow-up independent QA (2026-11-07): keep this stack draft

Code review flagged four concrete path/integrity risks to address before merging. These are static review findings, not yet reproduced exploits:

  1. Voice/cue TOCTOU: cue-provenance.ts verifies hashes, then render/rev2d.ts reopens cues and FFmpeg later reopens the audio path. File replacement between verification and consumption may bypass the exact-byte guarantee. Test post-verify swaps and bind an immutable read snapshot to consumption.
  2. Rig provenance TOCTOU: model/texture paths can be reopened by the backend after fingerprint verification. Test a swap at the verification/render boundary; protect the loaded rig and texture snapshot.
  3. Frame-output symlink escape: render/rev2d.ts uses lexical insideRoot for generated frames; an existing in-root symlink ancestor could redirect writes outside the workspace. Canonicalize parent directories and verify the final output target before creating files.
  4. Custom-root boundary: loadAndValidateScene(...,{root}) constrains scene/actors to that root, while optional voice/cue binding verification uses process.cwd(). Validate audio/cues/sidecar against the same explicit root and return clear diagnostics on escapes.

Existing green tests and the verified demo video do not eliminate these concurrency/path risks. Keep #10 and stacked #11 as drafts until focused regressions and a safe real render pass. No user art, private recordings or secrets are included here.

@nkcbuilds

Copy link
Copy Markdown
Owner Author

Follow-up remediation is available in stacked draft PR #12 (fix/verified-render-inputs), on top of #11: verified per-render rig/texture and bound WAV/cue snapshots, fresh symlink-checked frame roots, and strict options.root confinement. Local suite: 211 tests in 36 files passed. Two 45-frame MP4 smoke tests passed, including an imported-art QA-only forced approval on a disposable copy. Both GitHub validation checks passed. This is still not a hostile same-user filesystem sandbox; original character art remains unapproved and the stacked PRs should not be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant