Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Follow-up independent QA (2026-11-07): keep this stack draftCode review flagged four concrete path/integrity risks to address before merging. These are static review findings, not yet reproduced exploits:
Existing green tests and the verified demo video do not eliminate these concurrency/path risks. Keep #10 and stacked #11 as drafts until focused regressions and a safe real render pass. No user art, private recordings or secrets are included here. |
|
Follow-up remediation is available in stacked draft PR #12 (fix/verified-render-inputs), on top of #11: verified per-render rig/texture and bound WAV/cue snapshots, fresh symlink-checked frame roots, and strict options.root confinement. Local suite: 211 tests in 36 files passed. Two 45-frame MP4 smoke tests passed, including an imported-art QA-only forced approval on a disposable copy. Both GitHub validation checks passed. This is still not a hostile same-user filesystem sandbox; original character art remains unapproved and the stacked PRs should not be automatically merged. |
Goal
Make PuppetControl's existing reviewed-character first-video workflow more usable for actual new illustrations by integrating the two earlier draft quality branches (#7 and #8), rendering an actionable blink-review sheet, and ensuring optional voice/Rhubarb cue integrity. This branch is stacked on draft PR #9 (
feat/first-video-mvp) and must not be merged independently intomain.Changes
character qa blink <imported-project>: validate provenance, render 13 real Rev2D eye states at transition boundaries, mirror to 25-frame ordered review montage, generate enlarged eye/full contact sheets and motion-stall JSON. Source/rig/approval unchanged.audio bind,audio verify,scene new --binding. Bound scenes independently verify WAV and Rhubarb cue SHA-256 before validation and rendering and fail if tampered/moved. Legacy unbound scenes still work.docs/CHARACTER_REVIEW.mdoutlines correction workflow and explicit visual approval; documentation/skills refreshed.Real evidence
.cache/avatar-onboarding/short-fade-import-20261107has correct source/rig fingerprints, approved:false. Commandcharacter qa blinksuccessfully produced 25 frames and local contact sheets under ignoredoutputs/qa/blink-review/85cb4479-ad75-40a2-8940-377de4bba860. Inspected the actual montage: still has skin-color patches, ghost lashes and unnatural half-eye states. 10 sampled motion-stall candidates; these are triage, not proof of defects.scene newwith--bindingandscene validatepassed. Rendered 3s H.264/AAC video at 512x640, 15fps, 45 frames. FFprobe checker PASS; one video + one audio stream. All voice/model/test art stays ignored/local.npm run verify: 188 tests across 32 files passed, TypeScript typecheck/build green.git diff --checkclean, working tree clean.Explicit blockers, do not mark production-ready