Conversation
`enableDefensive()` updated only the live connection, so after `close()` and `open()` the defensive flag went back to the value passed to the constructor. Store the new value in the open configuration so that `open()` applies it again. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66404 +/- ##
==========================================
+ Coverage 90.36% 90.39% +0.02%
==========================================
Files 792 792
Lines 275564 275565 +1
Branches 52832 52829 -3
==========================================
+ Hits 249016 249084 +68
+ Misses 16965 16911 -54
+ Partials 9583 9570 -13
🚀 New features to boost your workflow:
|
araujogui
reviewed
Sep 30, 2026
trivikr
added
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
trivikr
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
trivikr
added
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66403
enableDefensive()updated only the live connection, so afterclose()andopen()the defensive flag went back to the value passed to the constructor.Store the new value in the open configuration so that
open()applies it again.Assisted-by: claude:opus-5.5