Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/node_sqlite.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3538,6 +3538,7 @@ void Database::EnableDefensive(const FunctionCallbackInfo<Value>& args) {
enable,
&defensive_enabled);
CHECK_ERROR_OR_THROW(isolate, db, defensive_ret, SQLITE_OK, void());
db->open_config_.set_enable_defensive(enable);
}

void Database::LoadExtension(const FunctionCallbackInfo<Value>& args) {
Expand Down
20 changes: 20 additions & 0 deletions test/parallel/test-sqlite-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,26 @@ test('defensive mode off after calling db.enableDefensive(false)', (t) => {
t.assert.strictEqual(checkDefensiveMode(db), false);
});

test('db.enableDefensive(true) persists across close() and open()', (t) => {
const db = new Database(':memory:', {
Comment thread
trivikr marked this conversation as resolved.
defensive: false
});
db.enableDefensive(true);
db.close();
db.open();
t.assert.strictEqual(checkDefensiveMode(db), true);
});

test('db.enableDefensive(false) persists across close() and open()', (t) => {
const db = new Database(':memory:', {
defensive: true
});
db.enableDefensive(false);
db.close();
db.open();
t.assert.strictEqual(checkDefensiveMode(db), false);
});

test('throws if options.defensive is provided but is not a boolean', (t) => {
t.assert.throws(() => {
new Database(':memory:', { defensive: 42 });
Expand Down
Loading