Repository navigation
sn/object: Fix unchecked known length of unfinished objects in PUT - #4233
Merged
Merged
Conversation
cthulhu-rider
force-pushed
the
put-payload-len
branch
from
October 16, 2026 10:13
7c88c76 to
c31b100
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4233 +/- ##
==========================================
- Coverage 32.21% 32.20% -0.02%
==========================================
Files 674 674
Lines 41343 41348 +5
==========================================
- Hits 13320 13317 -3
- Misses 28023 28031 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
put-payload-len
branch
from
October 16, 2026 14:36
c31b100 to
502e482
Compare
cthulhu-rider
marked this pull request as ready for review
October 16, 2026 16:02
cthulhu-rider
requested review from
End-rey,
carpawell and
roman-khimov
as code owners
October 16, 2026 16:02
roman-khimov
requested changes
Oct 19, 2026
cthulhu-rider
force-pushed
the
put-payload-len
branch
from
October 21, 2026 14:59
502e482 to
df761a6
Compare
According to API, unknown length of unprepared object must be set to 0xFFFFFFFFFFFFFFFF. Otherwise, number of payload bytes sent must equal the field value. Previously, PUT server never checked the payload length of unfinished objects. However, clients could leave the value unspecified (zero) due to carelessness. Therefore, this adds a zero-exclusion check. Fixes #4208. Signed-off-by: Leonard Liubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
put-payload-len
branch
from
October 21, 2026 15:20
df761a6 to
9803161
Compare
roman-khimov
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.