Skip to content

sn/object: Fix unchecked known length of unfinished objects in PUT #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roman-khimov merged 1 commit into from
Oct 22, 2026
Merged

sn/object: Fix unchecked known length of unfinished objects in PUT #4233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Changelog for NeoFS Node
- Setting eACL without API version in CLI (#4229)
- Unnecessary local shard relocation of EC parts by policer (#4236)
- GC stalling on expired objects protected by LOCKs stored only on other shards (#4237)
- Unchecked known payload length of unfinished objects in PUT (#4233)

### Changed
- SN now requires requests to have API version >= 2.22 (#4212)
Expand Down
23 changes: 19 additions & 4 deletions pkg/services/object/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"errors"
"fmt"
"io"
"math"
"slices"
"strings"
"sync"
Expand Down Expand Up @@ -309,7 +310,8 @@ type putStream struct {
initReq *protoobject.PutRequest
chunkReqs []*protoobject.PutRequest

expBytes, recvBytes uint64 // payload
knownPayloadLength bool
expBytes, recvBytes uint64 // payload (undefined if knownPayloadLength is false)
}

func newIntermediatePutStream(signer ecdsa.PrivateKey, base *putsvc.Streamer, ctx context.Context, log *zap.Logger) *putStream {
Expand Down Expand Up @@ -378,11 +380,24 @@ func (x *putStream) forwardInitRequest(req *protoobject.PutRequest, initPart *pr
return fmt.Errorf("could not init object put stream: %w", err)
}

ln := initPart.Header.GetPayloadLength()

// Max is a special value defined in the protocol. Zero is also treated as
// unknown because server never prohibited such requests, but clients often
// forgot to explicitly set the value.
x.knownPayloadLength = ln > 0 && ln != math.MaxUint64
if x.knownPayloadLength {
x.expBytes = ln
}

if x.cacheReqs = initPart.Signature != nil; !x.cacheReqs {
return nil
}

x.expBytes = initPart.Header.GetPayloadLength()
if ln == math.MaxUint64 {
return putsvc.ErrExceedingMaxSize
Comment thread
roman-khimov marked this conversation as resolved.
}

if m := x.base.MaxObjectSize(); x.expBytes > m {
return putsvc.ErrExceedingMaxSize
}
Expand All @@ -391,7 +406,7 @@ func (x *putStream) forwardInitRequest(req *protoobject.PutRequest, initPart *pr
}

func (x *putStream) forwardChunkRequest(req *protoobject.PutRequest, c []byte) error {
if x.cacheReqs {
if x.knownPayloadLength {
if x.recvBytes += uint64(len(c)); x.recvBytes > x.expBytes {
return putsvc.ErrWrongPayloadSize
}
Expand All @@ -407,7 +422,7 @@ func (x *putStream) forwardChunkRequest(req *protoobject.PutRequest, c []byte) e
}

func (x *putStream) close() (*protoobject.PutResponse, error) {
if x.cacheReqs && x.recvBytes != x.expBytes {
if x.knownPayloadLength && x.recvBytes != x.expBytes {
return nil, putsvc.ErrWrongPayloadSize
}

Expand Down
Loading