Repository navigation
fix: lay out the largest diagrams without crashing, plus phone zoom and large-diagram speed - #59
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 0.6.0-rc.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
Contributor
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the viewer test run: big diagrams on phones, large-diagram layout speed and a crash, and viewer speed at 500 nodes.
Evidence
Before:
stackmap deliver(Node) on 500 nodes / 1,500 connections →internal error: Maximum call stack size exceeded.After: delivered in 7 s. Worst case the schema allows (500 / 2,000, ungrouped): 19 s.
Before: new test
lays out the largest diagram the schema allows without overflowing the stackfails (timeout on old settings, stack overflow with in-process ELK). After: passes.Viewer, 500 nodes, Chrome trace in headless Chromium (main thread / raster):
typecheck, all unit tests (core 90, schema 108, viewer 158, layout 726, CLI 49), Bun smoke check, and in the CI Docker image viewer e2e 109/109 with
VISUAL=1and CLI e2e 7/7.Merge Danger
Door: two-way
Diagrams of 60 nodes or fewer lay out exactly as before (no baseline changed). Larger ones no longer keep the author's node order and may cross a few more edges.
Blast Radius: large-diagrams
Layout and viewer behaviour change only past 60 nodes / 180 edges, plus the opening zoom on phone-width stages. Still open: under Bun, an ungrouped 500-node / 2,000-edge diagram overflows (Bun can't raise its stack); the published CLI runs on Node.