Repository navigation
fix(viewer): keep the flow playing when its speed changes - #63
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 0.6.1-rc.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
Contributor
|
🎉 This PR is included in version 0.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Clicking the flow speed button while the flow plays snapped every pulse back to the start of the loop.
FlowLayerreads the speed from a ref so that a change carries on without a jump, butExploreProviderrecomputedemphasison every state change, includingspeed,playingandreveal. That built a newFlow, and the layer's effect restarted its clock at 0.emphasisnow takes anEmphasisInput(aPickof the 8 fields it reads), and the memo depends on exactly those fields. Playback toggles no longer rebuild emphasis or the edge layer.How it was checked
src/explore/ExploreContext.test.tsx:togglePlayandcycleSpeed;[draft, graph, state].bun run test,bun run typecheckandbun run buildpass.e2e/flow.spec.tsande2e/explore.spec.tscould not run locally (Chromium is missing system libraries), so CI's e2e job covers them.