Repository navigation
fix(cli): quote the path deliver --open hands to cmd on Windows - #64
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
|
🎉 This PR is included in version 0.6.1-rc.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
Contributor
|
🎉 This PR is included in version 0.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
On Windows,
deliver --openrancmd /c start "" <path>withwindowsVerbatimArguments, so Node passed the path unquoted. Two problems followed:C:\Users\First Last\…) was cut off and didn't open;&,|,^or parentheses in a file name made cmd run the rest as a command.The path is now wrapped in double quotes, inside which cmd takes those characters literally. Windows file names can't contain
". Paths containing%or"aren't opened at all, because cmd expands%VAR%even inside quotes. In that case deliver still writes the file and prints its usual "couldn't open … in a browser" warning. macOS and Linux are unchanged.How it was checked
test/open.test.tscovers:&and parentheses inside the quotes;%and";bun run test,bun run typecheckandbun run buildpass.deliver "C:\Users\<name with space>\d.json" --openonce.